From: Roman Zippel <zippel@linux-m68k.org>
To: Thunder from the hill <thunder@ngforever.de>
Cc: Dawson Engler <engler@csl.stanford.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<mc@cs.stanford.edu>
Subject: Re: [CHECKER] 56 potential lock/unlock bugs in 2.5.8
Date: Fri, 12 Jul 2002 19:40:35 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.44.0207121934420.8911-100000@serv> (raw)
In-Reply-To: <Pine.LNX.4.44.0207111711530.26269-100000@hawkeye.luckynet.adm>
Hi,
On Thu, 11 Jul 2002, Thunder from the hill wrote:
> --- fs/affs/namei.c 19 Jun 2002 02:11:51 -0000 1.1.1.1
> +++ fs/affs/namei.c 11 Jul 2002 22:36:41 -0000
> @@ -345,10 +345,14 @@ affs_rmdir(struct inode *dir, struct den
> lock_kernel();
>
> /* WTF??? */
> + res = -ENOENT;
> +
> if (!dentry->d_inode)
> - return -ENOENT;
> + goto out_unlock;
>
> res = affs_remove_header(dentry);
> +
> + out_unlock:
> unlock_kernel();
> return res;
> }
Please drop this patch, it's impossible to hit this problem and I have a
better patch for this.
bye, Roman
next prev parent reply other threads:[~2002-07-12 17:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-11 21:35 Dawson Engler
2002-07-11 21:54 ` Thunder from the hill
2002-07-11 22:21 ` Oliver Neukum
2002-07-11 23:14 ` Thunder from the hill
2002-07-11 23:32 ` Andreas Dilger
2002-07-11 23:45 ` Thunder from the hill
2002-07-11 23:41 ` Chris Wright
2002-07-12 0:21 ` Andrew Morton
2002-07-12 1:44 ` Arnaldo Carvalho de Melo
2002-07-12 17:40 ` Roman Zippel [this message]
2002-07-12 17:53 ` Thunder from the hill
2002-07-12 18:37 ` Roman Zippel
2002-07-12 18:05 ` Dave Jones
2002-07-12 18:32 ` Roman Zippel
2002-07-12 18:37 ` Dave Jones
2002-07-12 20:34 ` Roman Zippel
2002-07-12 20:48 ` Dave Jones
2002-07-12 21:30 ` Roman Zippel
2002-07-12 21:38 ` Dave Jones
2002-07-12 21:56 ` Roman Zippel
2002-07-12 22:14 ` Dave Jones
2002-07-12 22:34 ` Roman Zippel
2002-07-12 22:41 ` Dave Jones
2002-07-12 13:17 ` David Woodhouse
2002-07-12 13:26 ` Thunder from the hill
2002-07-11 22:32 Grover, Andrew
2002-07-11 23:26 ` Dawson Engler
[not found] <200207112135.OAA03801@csl.Stanford.EDU.suse.lists.linux.kernel>
2002-07-11 22:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0207121934420.8911-100000@serv \
--to=zippel@linux-m68k.org \
--cc=engler@csl.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
--cc=thunder@ngforever.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®