From: Hugh Dickins <hugh@veritas.com>
To: Matthew Wilcox <willy@debian.org>
Cc: Andrew Morton <akpm@zip.com.au>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] shmem missing cache flush
Date: Thu, 17 Oct 2002 00:57:30 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.44.0210170033320.1476-100000@localhost.localdomain> (raw)
In-Reply-To: <20021016192630.L15163@parcelfarce.linux.theplanet.co.uk>
On Wed, 16 Oct 2002, Matthew Wilcox wrote:
>
> Really, this should be a clear_user_page(), but we can't reasonable get
> a user address all the way down to it, so let's just flush it instead.
> Note that 2.4 needs an equivalent fix.
>
> diff -urpNX build-tools/dontdiff linus-2.5/mm/shmem.c parisc-2.5/mm/shmem.c
> --- linus-2.5/mm/shmem.c Tue Oct 8 10:54:20 2002
> +++ parisc-2.5/mm/shmem.c Tue Oct 8 16:49:24 2002
> @@ -848,6 +848,7 @@ repeat:
> info->alloced++;
> spin_unlock(&info->lock);
> clear_highpage(page);
> + flush_dcache_page(page);
> SetPageUptodate(page);
> }
I expect you're right - even though that page is not yet mapped into
any user address space? I'm currently preparing a shmem.c patch set
to send Andrew in the next day or two, so I'll factor that in too.
I would be much happier about adding it, if you could tell me that
I can then remove the flush_page_to_ram(page) from shmem_nopage?
But suspect you won't grant me that: notice that 2.4.18 and 2.5.3
added flush_dcache_page in addition to flush_page_to_ram in
memclear_highpage_flush, which I'll take as definitive.
To x86ers, flush_page_to_ram, flush_dcache_page, flush_icache_page
etc. all seem like forlorn prayers to different gods, "Please, let
my data be seen by the user". Documentation/cachetlb.txt has for
a long time told us that flush_page_to_ram (sacrifice ram to page
god) is now deprecated, the new religion is flush_dcache_page,
and flush_icache_page can soon be forgotten. But they're all
still there to confuse us; and it seems that years can go by
without the high priests noticing where these prayers are needed.
In view of which, I don't expect to be rushing a 2.4.20 fix to
Marcelo: let it ride until 2.4.21, okay?
Hugh
next prev parent reply other threads:[~2002-10-16 23:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-16 18:26 Matthew Wilcox
2002-10-16 23:57 ` Hugh Dickins [this message]
2002-10-16 23:58 ` David S. Miller
2002-10-17 0:19 ` Russell King
2002-10-17 0:16 ` David S. Miller
2002-10-21 15:04 ` Alan Cox
2002-10-21 15:21 ` David S. Miller
2002-10-21 16:12 ` Alan Cox
2002-10-28 14:10 ` David S. Miller
2002-10-28 14:32 ` Matthew Wilcox
2002-10-28 14:26 ` David S. Miller
2002-10-28 16:36 ` Matthew Wilcox
2002-10-28 16:55 ` David S. Miller
2002-10-28 17:06 ` Matthew Wilcox
2002-10-28 16:58 ` David S. Miller
2002-10-29 21:52 ` Matthew Wilcox
2002-10-28 17:08 ` Alan Cox
2002-10-28 16:52 ` Matthew Wilcox
2002-10-28 14:35 ` Hugh Dickins
2002-10-28 14:26 ` David S. Miller
2002-10-28 16:50 Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0210170033320.1476-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®