mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Aaron Lehmann <aaronl@vitelus.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] check QT only if needed
Date: Thu, 31 Oct 2002 10:36:42 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.44.0210311032530.13258-100000@serv> (raw)
In-Reply-To: <20021031013436.GG23438@vitelus.com>

Hi,

On Wed, 30 Oct 2002, Aaron Lehmann wrote:

> Now running 'make oldconfig' or 'make menuconfig' requires a Qt
> installation. I believe that this is a bug because these still work
> fine without Qt when the -k flag is passed to make.

Yes, it's a bug. The patch below fixes this without breaking xconfig.
Linus, please apply.

bye, Roman

# Only check for the qt installation if a qconf build is requested

--- linux-2.5/scripts/kconfig/Makefile.org	2002-10-28 00:15:29.000000000 +0100
+++ linux-2.5/scripts/kconfig/Makefile	2002-10-31 10:23:07.000000000 +0100
@@ -34,6 +34,7 @@
 
 $(obj)/qconf.o: $(obj)/.tmp_qtcheck
 
+ifeq ($(MAKECMDGOALS),$(obj)/qconf)
 -include $(obj)/.tmp_qtcheck
 
 # QT needs some extra effort...
@@ -52,6 +53,7 @@
 	LIB=qt; \
 	if [ -f $$DIR/lib/libqt-mt.so ]; then LIB=qt-mt; fi; \
 	echo "QTDIR=$$DIR" > $@; echo "QTLIB=$$LIB" >> $@
+endif
 
 $(obj)/zconf.tab.o: $(obj)/lex.zconf.c
 


  parent reply	other threads:[~2002-10-31  9:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-31  0:56 Linux v2.5.45 Linus Torvalds
2002-10-31  1:22 ` Udo A. Steinberg
2002-10-31  2:40   ` Neil Brown
2002-10-31  1:34 ` Aaron Lehmann
2002-10-31  1:44   ` Alexander Viro
2002-10-31  1:56     ` Jan Harkes
2002-10-31  9:36   ` Roman Zippel [this message]
2002-10-31  1:37 ` Adam Huffman
2002-10-31  1:49   ` Jeff Garzik
2002-10-31  8:58     ` Paul
2002-10-31  9:59   ` Joe Thornber
2002-10-31  2:56 ` Martin J. Bligh
2002-10-31  3:31   ` Greg KH
2002-10-31  3:03 ` Udo A. Steinberg
2002-10-31 10:40 ` Jochen Friedrich
2002-10-31 11:21   ` Jochen Friedrich
2002-10-31 11:18 ` Adrian Bunk
2002-11-01 10:29 ` Linux v2.5.45 ipmr.c compile failure Helge Hafting
2002-11-01 23:35   ` Randy.Dunlap
2002-11-02  1:13     ` various 2.5.45 compile problems (intermezzo, pmtu, afs, qt) (was: Linux v2.5.45 ipmr.c compile failure) Bernd Eckenfels
2002-11-01 11:29 ` Linux v2.5.45 Adrian Bunk
2002-11-01 12:58   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0210311032530.13258-100000@serv \
    --to=zippel@linux-m68k.org \
    --cc=aaronl@vitelus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®