mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Petr Baudis <pasky@ucw.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [kconfig] Single-menu mode support for make menuconfig
Date: Wed, 6 Nov 2002 14:11:24 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.44.0211061359000.6949-100000@serv> (raw)
In-Reply-To: <20021103211632.GB20338@pasky.ji.cz>

Hi,

On Sun, 3 Nov 2002, Petr Baudis wrote:

>   With this mode, when you enter a category, no new menu is open, but the
> category is unrolled to the current menu, thus the whole configuration is
> forming one single tree. Some users prefer this as a form of configuration, as
> they consider it easier to take in than the classical behaviour.

It looks mostly ok.

> diff -ru linux/scripts/kconfig/expr.h linux+pasky/scripts/kconfig/expr.h
> --- linux/scripts/kconfig/expr.h	Sun Nov  3 15:24:01 2002
> +++ linux+pasky/scripts/kconfig/expr.h	Sun Nov  3 15:00:17 2002
> @@ -169,6 +169,7 @@
>  	//char *help;
>  	struct file *file;
>  	int lineno;
> +	int expanded; /* solely for frontend use */
>  	//void *data;
>  };

The menu structure is mostly readonly, if front ends need to store 
something there, I'd rather reactivate the data field (which was meant for 
this, but it's currently not used).

> @@ -682,6 +699,9 @@
>  int main(int ac, char **av)
>  {
>  	int stat;
> +
> +	single_menu_mode = !!getenv("SINGLE_MENU");
> +
>  	conf_parse(av[1]);
>  	conf_read(NULL);
>  

Could you give it a different name (MENUCONFIG_MODE?) and check it 
contents instead of just testing for existence?

> diff -ru linux/scripts/lxdialog/util.c linux+pasky/scripts/lxdialog/util.c
> --- linux/scripts/lxdialog/util.c	Sun Nov  3 15:24:21 2002
> +++ linux+pasky/scripts/lxdialog/util.c	Sun Nov  3 15:11:44 2002
> @@ -348,7 +348,7 @@
>  		c = tolower(string[i]);
>  
>  		if (strchr("<[(", c)) ++in_paren;
> -		if (strchr(">])", c)) --in_paren;
> +		if (strchr(">])", c) && in_paren > 0) --in_paren;
>  
>  		if ((! in_paren) && isalpha(c) && 
>  		     strchr(exempt, c) == 0)

What's this needed for?

bye, Roman


  reply	other threads:[~2002-11-06 13:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-03 21:16 Petr Baudis
2002-11-06 13:11 ` Roman Zippel [this message]
2002-11-06 14:18   ` [PATCH] [kconfig] Single-menu mode support for make menuconfig II Petr Baudis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0211061359000.6949-100000@serv \
    --to=zippel@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasky@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®