From: Davide Libenzi <davidel@xmailserver.org>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Janet Morgan <janetinc@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.5.46: epoll ep_insert doesn't wake waiters if events exist
Date: Thu, 7 Nov 2002 15:24:36 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.44.0211071521070.1751-100000@blue1.dev.mcafeelabs.com> (raw)
In-Reply-To: <OF0E49851E.BBF9BCB0-ON88256C6A.007C9078@boulder.ibm.com>
On Thu, 7 Nov 2002, Jay Vosburgh wrote:
>
> The logic in fs/eventpoll.c:ep_insert() checks to see if events are
> already present when processing an EP_CTL_ADD operation, and, if any are,
> adds them to the list. It does not wake up any waiters, so, e.g., another
> thread waiting in epoll_wait() will not be awakened for these events. The
> fix is to have ep_insert() do wakeups, just as ep_poll_callback() does when
> it adds events.
Matthew Kirk already made me notice this yesterday and it's in my code ( 0.37 ).
I was ashame to make another post to Linus :) so I delayed the post.
Linus, I have a few bits. Let me know if you want them now or we will
delay to 2.5.47 ...
- Davide
next prev parent reply other threads:[~2002-11-07 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-07 22:53 Jay Vosburgh
2002-11-07 23:24 ` Davide Libenzi [this message]
2002-11-08 15:49 ` Mark Hamblin
2002-11-08 17:43 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0211071521070.1751-100000@blue1.dev.mcafeelabs.com \
--to=davidel@xmailserver.org \
--cc=fubar@us.ibm.com \
--cc=janetinc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®