mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Norbert Kiesel <nkiesel@tbdnetworks.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Multiple & vs. && and | vs. || bugs in 2.4.20
Date: Sun, 2 Mar 2003 19:25:43 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.44.0303021919180.32518-100000@serv> (raw)
In-Reply-To: <3E6247F7.8060301@redhat.com>

Hi,

On Sun, 2 Mar 2003, Ulrich Drepper wrote:

> > -	if (!urb->status & !acm->throttle)  {
> > +	if (!urb->status && !acm->throttle)  {
> 
> [...]
> 
> Observe the extra 'jne' and the fact that the value of 'throttle'
> element cannot be loaded until after the conditional jump.   Not even
> out of order execution can arrange that.

But speculative execution can arrange that (providing the cpu predicted 
the jump target correctly).

> To summarize, I'd probably not be amused if you would change any of my
> code which takes advantage of such programming finess.

If that was really intentional, I would assume to see something like this:

	if (!(urb->status | acm->throttle)) {

bye, Roman


  reply	other threads:[~2003-03-02 18:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-02 12:14 Norbert Kiesel
2003-03-02 18:05 ` Ulrich Drepper
2003-03-02 18:25   ` Roman Zippel [this message]
2003-03-02 21:41   ` Werner Almesberger
2003-03-02 22:03     ` Richard Henderson
2003-03-03  2:03   ` Norbert Kiesel
2003-03-03  3:02     ` John Levon
2003-03-06 19:58   ` Pavel Machek
2003-03-07 18:45     ` Norbert Kiesel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0303021919180.32518-100000@serv \
    --to=zippel@linux-m68k.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nkiesel@tbdnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®