mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Andi Kleen <ak@colin.muc.de>
Cc: Linus Torvalds <torvalds@transmeta.com>, Andi Kleen <ak@muc.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters
Date: Sun, 15 Jun 2003 19:48:56 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.44.0306151943100.12110-100000@serv> (raw)
In-Reply-To: <20030615193256.29257@colin.muc.de>

Hi,

On 15 Jun 2003, Andi Kleen wrote:

> I tend to agree, feel free to flame them. But it doesn't help me right now 
> when I want to get a booting kernel. Could you merge that change or if you 
> prefer I can rewrite it to anonymous asm (but it will be probably more ugly). 
> I just need some workaround.

Does the patch below work better?

bye, Roman

--- linux/init/main.c	14 Jun 2003 23:01:48 -0000	1.1.1.41
+++ linux/init/main.c	15 Jun 2003 17:46:16 -0000
@@ -383,7 +383,7 @@ asmlinkage void __init start_kernel(void
 {
 	char * command_line;
 	extern char saved_command_line[];
-	extern struct kernel_param __start___param, __stop___param;
+	extern struct kernel_param __start___param[], __stop___param[];
 /*
  * Interrupts are still disabled. Do necessary setups, then
  * enable them
@@ -403,8 +403,8 @@ asmlinkage void __init start_kernel(void
 	build_all_zonelists();
 	page_alloc_init();
 	printk("Kernel command line: %s\n", saved_command_line);
-	parse_args("Booting kernel", command_line, &__start___param,
-		   &__stop___param - &__start___param,
+	parse_args("Booting kernel", command_line, __start___param,
+		   __stop___param - __start___param,
 		   &unknown_bootoption);
 	trap_init();
 	rcu_init();



  reply	other threads:[~2003-06-15 17:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20030615131004$6a85@gated-at.bofh.it>
     [not found] ` <20030615170013$4ebc@gated-at.bofh.it>
2003-06-15 17:17   ` Andi Kleen
2003-06-15 17:24     ` Linus Torvalds
2003-06-15 17:32       ` Andi Kleen
2003-06-15 17:48         ` Roman Zippel [this message]
2003-06-15 18:28           ` Andi Kleen
2003-06-15 22:56           ` Richard Henderson
2003-06-15 12:58 Andi Kleen
2003-06-15 16:52 ` Linus Torvalds
2003-06-16  0:23   ` Rusty Russell
2003-06-16  0:49     ` Richard Henderson
2003-06-16  3:55       ` Rusty Russell
2003-06-16  2:44     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0306151943100.12110-100000@serv \
    --to=zippel@linux-m68k.org \
    --cc=ak@colin.muc.de \
    --cc=ak@muc.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®