From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272950AbTHEXPY (ORCPT ); Tue, 5 Aug 2003 19:15:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272974AbTHEXPY (ORCPT ); Tue, 5 Aug 2003 19:15:24 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:18194 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S272950AbTHEXPU (ORCPT ); Tue, 5 Aug 2003 19:15:20 -0400 Date: Wed, 6 Aug 2003 01:15:00 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@serv To: Andries.Brouwer@cwi.nl cc: B.Zolnierkiewicz@elka.pw.edu.pl, Subject: Re: [PATCH] fix error return get/set_native_max functions In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, 5 Aug 2003 Andries.Brouwer@cwi.nl wrote: > > This change is okay, thanks. > > However changing coding style is not... > > An interesting remark. > > I belong to the people who look at kernel source on a screen > with 80 columns. Code that is wider and wraps is unreadable. Get a better editor? While I think 80 columns is a worthwhile goal, I don't see a good reason to wrap a random line only because it exceeds the limit by a few characters. What is especially annoying are patches with a one line fix hidden within 10 other formatting changes (I've seen this already from you). Please respect others people code and try to avoid randoming formatting changes or at least keep them separate. bye, Roman