mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrea Arcangeli <andrea@suse.de>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	<parisc-linux@parisc-linux.org>
Subject: Re: [parisc-linux] rmap: parisc __flush_dcache_page
Date: Thu, 8 Apr 2004 15:16:39 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.44.0404081500520.7116-100000@localhost.localdomain> (raw)
In-Reply-To: <1081432370.2105.77.camel@mulgrave>

On 8 Apr 2004, James Bottomley wrote:
> On Thu, 2004-04-08 at 08:41, Hugh Dickins wrote:
> > Something to notice about that parisc __flush_dcache_page I sent you:
> > there's no locking around searching the tree for vmas; there was never
> > any locking around searching the list for vmas.  arm is similar, but
> > at least has no CONFIG_SMP, just a preemption issue.  Any ideas?
> 
> I don't think you sent it to the parisc list?

That's right, at present it's just something in Andrea's -aa tree
and Martin's -mjb tree.  Will try to remember to copy maintainers
when sending to Andrew.  But the problem was there before the patch.

> I'm afraid we've just been pretty heavily updating flush_dcache_page
> recently to fill a number of holes in the implementation.

Don't be afraid, that's good!  Is it still going vertically down
i_mmap_shared and i_mmap?  Whereas it's only interested in vmas of
the one mm, so could go horizontally along it.  Just an option to
play with, but I don't believe it solves anything, just as unsafe
when threaded.

> As far as list traversal goes...we don't require the list to freeze:
> acidentally flushing dead vmas would be harmless and added ones wouldn't
> need flushing,

Yes.

> so all we need would probably be a safe traversal and a
> reference to prevent the vma being deallocated.

Which we're not giving you at all at present.  I guess another layer
of spinlocking/nopreemption, for parisc and arm, dissolving to nothing
on other arches.

Hugh


  reply	other threads:[~2004-04-08 14:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-08 13:41 Hugh Dickins
2004-04-08 13:52 ` [parisc-linux] " James Bottomley
2004-04-08 14:16   ` Hugh Dickins [this message]
2004-04-08 14:40     ` James Bottomley
2004-04-08 15:14       ` Andrea Arcangeli
2004-04-08 15:28         ` James Bottomley
2004-04-08 15:34           ` Andrea Arcangeli
2004-04-08 15:47             ` James Bottomley
2004-04-08 16:16               ` Andrea Arcangeli
2004-04-08 16:29                 ` James Bottomley
2004-04-08 17:10                   ` Andrea Arcangeli
2004-04-08 17:43                     ` James Bottomley
2004-04-08 17:51                       ` Andrea Arcangeli
2004-04-08 18:07                         ` James Bottomley
2004-04-08 18:18                           ` Andrea Arcangeli
2004-04-08 18:28                             ` James Bottomley
2004-04-08 18:42                               ` Andrea Arcangeli
2004-04-08 18:49                                 ` James Bottomley
2004-04-08 19:02                                   ` Andrea Arcangeli
2004-04-10  1:21                                 ` Paul E. McKenney
2004-04-08 15:35         ` Hugh Dickins
2004-04-08 16:13           ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0404081500520.7116-100000@localhost.localdomain \
    --to=hugh@veritas.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parisc-linux@parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®