mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Tennert <tennert@science-computing.de>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH [NFSd] NFSv3/TCP
Date: Fri, 7 May 2004 09:19:58 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.44.0405070910440.5030-100000@picard.science-computing.de> (raw)
In-Reply-To: <16539.12572.90447.543633@cse.unsw.edu.au>

On Fri, 7 May 2004, Neil Brown wrote:

> On Friday May 7, tennert@science-computing.de wrote:
> > Hi Neil (and others),
> >
> > is there any reason why current 2.4 kernels do not allow for
> > NFSSVC_MAXBLKSIZE to become as large as 32k?
>
> Yes.
> At server thread creation, you need to be able to
>    kmalloc(NFSSVC_MAXBLKSIZE+1024)
> (or close to that) once per thread.  On most architectures this is a
> high-order alloc_pages and can often fail.
> Also, on every UDP write request, the server needs to 'kmalloc' a buffer
> to hold the whole request (actually on every request that is
> fragmented, but write is most common).  On most architectures, this
> kmalloc will again require allocative several contiguous pages, which
> can fail.
>
> So this patch is only safe if you have a large-patch arch or only use
> NFS over TCP.

So isn't it unsafe either with the NFSSVC_MAXBLKSIZE set to the original
8k? Or is it just less unsafe, then?

Anyway, I assure you the lockups occurred exactly when
server-side NFSv3/TCP got into the vanilla kernel at 2.4.19, and the only
significant difference I could see was this. I always used NFSv3/TCP
before then, and had no problems whatsoever. After that, I had to switch
to UDP.


>
> There was once a patch floating around which allowed a larger
> NFSSVC_MAXBLKSIZE on architectures with large page sizes, but it never
> got properly submitted I think.
>
>
> >
> > The problem is when I use NFSv3/TCP with a 2.4.25, say, on the server
> > side, as well as on the client side, I am experiencing lockups when
> > copying medium-sized or large files from the NFS fs to a local fs.
>
> There must be some other cause.  Increasing the NFSSVC_MAXBLKSIZE is
> just hiding a real problem I suspect.
>

If only the coincidence was not so clear.

Best regards and thanks

Oliver

__
________________________________________creating IT solutions

Dr. Oliver Tennert			science + computing ag
phone   +49(0)7071 9457-598		Hagellocher Weg 71-75
fax     +49(0)7071 9457-411		D-72070 Tuebingen, Germany
O.Tennert@science-computing.de		www.science-computing.de




  reply	other threads:[~2004-05-07  7:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-07  6:39 Oliver Tennert
2004-05-07  6:47 ` Neil Brown
2004-05-07  7:19   ` Oliver Tennert [this message]
2004-05-07  7:22   ` Greg Banks
2004-05-07  7:52     ` Oliver Tennert
2004-05-07  8:11       ` Greg Banks
2004-05-07  8:33         ` Strange Linux behaviour!? Oliver Pitzeier
2004-05-07  8:34           ` Christoph Hellwig
2004-05-07  9:01             ` Oliver Pitzeier
2004-05-07 17:25             ` Timothy Miller
2004-05-07 18:21               ` DervishD
2004-05-07  8:43           ` Keith Owens
2004-05-07 10:28             ` DervishD
2004-05-07  8:57           ` Dick Streefland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0405070910440.5030-100000@picard.science-computing.de \
    --to=tennert@science-computing.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®