From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263052AbTDQFBt (ORCPT ); Thu, 17 Apr 2003 01:01:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263055AbTDQFBt (ORCPT ); Thu, 17 Apr 2003 01:01:49 -0400 Received: from webhosting.rdsbv.ro ([213.157.185.164]:39094 "EHLO hosting.rdsbv.ro") by vger.kernel.org with ESMTP id S263052AbTDQFBq (ORCPT ); Thu, 17 Apr 2003 01:01:46 -0400 Date: Thu, 17 Apr 2003 08:13:26 +0300 (EEST) From: Catalin BOIE To: jamal cc: Catalin BOIE , Tomas Szepe , linux-kernel@vger.kernel.org, netdev@oss.sgi.com, manfred@colorfullife.com, kuznet@ms2.inr.ac.ru Subject: Re: [PATCH] qdisc oops fix In-Reply-To: <20030416072952.E4013@shell.cyberus.ca> Message-ID: References: <20030415084706.O1131@shell.cyberus.ca> <20030416072952.E4013@shell.cyberus.ca> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > This is a different problem from previous one posted. Same oops in slab.c:1128. Why do you think is different. > Theres a small window (exposed given that you are provisioning a lot > of qdiscs and running traffic at the same time) that an incoming packet > interupt will cause the BUG(). > > GFP_ATOMIC will fix it, but i wonder if it appropriate. > > Alexey or Manfred? > > cheers, > jamal > > PS:- 15mbits is not a lot of traffic ;-> Yes, I know. I was comparing 15mbit with almost no traffic on the machine running same qdiscs/filters/classes... :) > > On Wed, 16 Apr 2003, Catalin BOIE wrote: > > > > - sch = kmalloc(size, GFP_KERNEL); > > > + sch = kmalloc(size, GFP_ATOMIC); > > > > > > mysteriously fixes the problem? Could the problem be elsewhere? > > > Can you repost what the issue was? I am not on lk and i just saw the > > > posting on a web page. > > > > With many rules (~5000 classes and ~3500 qdiscs and ~50000 filters) > > the kernel oopses in slab.c:1128. > > It happens on high rates (~15mbit). > > On low rates, doesn't. > > > > Seems that an interrupt come and broke the memory allocation. > > > > > > >>EIP; c0127ab4 <===== > > > > >>EAX; ffffffff > > >>EBX; c12c52c0 > > >>EDI; c12c52c0 > > >>ESP; ceab1c60 > > > > Trace; c0127e0f > > Trace; c01d3cac > > Trace; d081ecc7 > > Trace; c01d5265 > > Trace; d0820600 > > Trace; c01d27e4 > > Trace; c01d0605 <__neigh_event_send+89/1b4> > > Trace; c01d7cd4 > > Trace; c01d7730 > > Trace; c01d7b73 > > Trace; c01c79d5 > > Trace; c01c8b48 > > Trace; c0120010 > > > > > --- Catalin(ux) BOIE catab@deuroconsult.ro