mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruen@suse.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4: Fix steal_locks race
Date: Sat, 9 Aug 2003 05:17:15 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.53.0308090514430.18879@Chaos.suse.de> (raw)
In-Reply-To: <20030809030409.GA11867@gondor.apana.org.au>

On Sat, 9 Aug 2003, Herbert Xu wrote:

> On Sat, Aug 09, 2003 at 04:59:03AM +0200, Andreas Gruenbacher wrote:
> >
> > @@ -714,18 +715,16 @@ static int load_elf_binary(struct linux_
> >  			elf_entry = load_elf_interp(&interp_elf_ex,
> >  						    interpreter,
> >  						    &interp_load_addr);
> > -
> > -		allow_write_access(interpreter);
> > -		fput(interpreter);
> > -		kfree(elf_interpreter);
> > -
> >  		if (BAD_ADDR(elf_entry)) {
> >  			printk(KERN_ERR "Unable to load interpreter\n");
> > -			kfree(elf_phdata);
> >  			send_sig(SIGSEGV, current, 0);
> >  			retval = -ENOEXEC; /* Nobody gets to see this, but.. */
> > -			goto out;
> > +			goto out_free_dentry;
> >  		}
> > +
> > +		allow_write_access(interpreter);
> > +		fput(interpreter);
> > +		kfree(elf_interpreter);
> >  	}
>
> This looks bad since you're past the point of no return.

This is an equivalence transformation except for the explicit
sys_close(elf_exec_fileno) in the unwind code, which would eventually
happen, anyway.

      reply	other threads:[~2003-08-09  3:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-08 10:53 Herbert Xu
2003-08-09  1:07 ` Herbert Xu
2003-08-09  1:11   ` [PATCH] 2.4: Restore current->files in flush_old_exec Herbert Xu
2003-08-09  1:48     ` Andreas Gruenbacher
2003-08-09  1:48     ` Herbert Xu
2003-08-09  2:20       ` Andreas Gruenbacher
2003-08-09  2:53         ` Herbert Xu
2003-08-09  3:01           ` Andreas Gruenbacher
2003-08-09  3:19             ` Andreas Gruenbacher
     [not found]               ` <Pine.LNX.4.53.0308090554160.18879@Chaos.suse.de>
     [not found]                 ` <20030809100518.GA14688@gondor.apana.org.au>
2003-08-09 10:41                   ` Andreas Gruenbacher
2003-08-09  1:46   ` [PATCH] 2.4: Fix steal_locks race Andreas Gruenbacher
2003-08-09  2:04   ` Andreas Gruenbacher
2003-08-09  2:52     ` Herbert Xu
2003-08-09  3:13       ` Andreas Gruenbacher
2003-08-09  3:19         ` Herbert Xu
2003-08-09  3:30           ` Andreas Gruenbacher
2003-08-09  2:59 ` Andreas Gruenbacher
2003-08-09  3:04   ` Herbert Xu
2003-08-09  3:17     ` Andreas Gruenbacher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.53.0308090514430.18879@Chaos.suse.de \
    --to=agruen@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®