mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Richard B. Johnson" <root@chaos.analogic.com>
To: Dave Jones <davej@redhat.com>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: FDC motor left on
Date: Mon, 6 Oct 2003 08:42:11 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.53.0310060834180.8593@chaos> (raw)
In-Reply-To: <20031003235801.GA5183@redhat.com>

On Sat, 4 Oct 2003, Dave Jones wrote:

> On Fri, Oct 03, 2003 at 01:25:30PM -0400, Richard B. Johnson wrote:
>  > In linux-2.4.22 and earlier, if there is no FDC driver installed,
>  > the FDC motor may continue to run after boot if the motor was
>  > started as part of the BIOS boot sequence.
>  > This patch turns OFF the motor once Linux gets control.
>  >
>  >
>  > --- linux-2.4.22/arch/i386/boot/setup.S.orig	Fri Aug  2 20:39:42 2002
>  > +++ linux-2.4.22/arch/i386/boot/setup.S	Fri Oct  3 11:50:43 2003
>  > @@ -59,6 +59,8 @@
>
> Does this mean the 'kill_motor' function in bootsect.S isn't doing
> what it should be? If so, maybe that needs fixing instead of turning
> it off in two places ?
>
> 		Dave

Yes. I didn't even see that. The code there makes me kinda sick.
Anyway, the kill_motor function executes "reset diskette/disk" function
which will never turn OFF the drive. Instead, it will restart
the motor timer because, as a condition of reseting the diskette,
it must make sure the motor is running.

I suggest that the FDC control byte be read, then the result be
ANDed with ~0x10, then written back. The ifed-out code clears
the whole control word which is inappropriate at a time the
diskette channel may be still be active.

Cheers,
Dick Johnson
Penguin : Linux version 2.4.22 on an i686 machine (797.90 BogoMips).
            Note 96.31% of all statistics are fiction.



  reply	other threads:[~2003-10-06 12:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-03 17:25 Richard B. Johnson
2003-10-03 23:58 ` Dave Jones
2003-10-06 12:42   ` Richard B. Johnson [this message]
2003-10-06 12:50     ` Maciej W. Rozycki
2003-10-06 12:59     ` Mikael Pettersson
2003-10-06 13:58       ` Richard B. Johnson
2003-10-06 14:25         ` John Bradford
2003-10-06 15:09           ` Richard B. Johnson
2003-10-06 15:49             ` Maciej W. Rozycki
2003-10-06 16:17               ` Richard B. Johnson
2003-10-06 16:46                 ` Maciej W. Rozycki
2003-10-06 16:06             ` John Bradford
2003-10-06 16:22               ` Richard B. Johnson
2003-10-06 16:41                 ` John Bradford
2003-10-04 13:56 Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.53.0310060834180.8593@chaos \
    --to=root@chaos.analogic.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®