From: "Richard B. Johnson" <root@chaos.analogic.com>
To: Oliver Dain <odain2@mindspring.com>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: proper place for devfs_register_chrdev with pci_module_init
Date: Wed, 4 Feb 2004 16:30:57 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.53.0402041616230.3277@chaos> (raw)
In-Reply-To: <18852317.1075926209540.JavaMail.root@wamui01.slb.atl.earthlink.net>
On Wed, 4 Feb 2004, Oliver Dain wrote:
> I'm writing a char driver for a PCI card. Looking at examples of such things I've found that most have a module_init like this:
>
> int foo_init(void)
> {
> /* stuff... */
> devfs_register_chrdev(...);
> /* more stuff... */
> pci_module_init(...);
> }
>
> This seems strange to me. The devfs_register_chrdev call will register
> the module and cause it to be held in memory even if the associated
> PCI device isn't present on the system. It seems like a better way
> to do this is to have the init method just call pci_module_init(...)
> and then in that method, after the PCI device has been initialized, call
> devfs_register_chrdev to associate the driver with the device. That way
> the kernel can unload the module if no such device is present, but if
> the device is present (or if one appears via hotplug) the module will
> be loaded and can then register itself. Will this work? Is there a
> reason people don't do this?
>
First! Fix your mailer. There wasn't a '\n' in the entire bunch
of text above. Unix/Linux people use the [Enter] key and don't
just auto-warp around the screen.
> I'm not subscribed to the LKML so please CC me on any responses.
>
> Thanks,
> Oliver
Well the "standard way" to start up a module is to allocate
resources for the module (like RAM), then register the module.
Then if the device isn't found, it's unregistered and the resources
freed. If the code to which you refer doesn't free its resources,
including unregistering if the device isn't found, then it's a bug.
Otherwise it doesn't make any difference. You can certainly probe
the PCI bus for your device first, and if it isn't found, you just
return -ENODEV or whatever. It's entirely up to you.
What is important is to make sure that you free any resources
that you acquired (like address space) if you decide not to
install the module. This makes it so you can write the module,
debug it, and add functionality without ever having to re-boot.
Cheers,
Dick Johnson
Penguin : Linux version 2.4.24 on an i686 machine (797.90 BogoMips).
Note 96.31% of all statistics are fiction.
next prev parent reply other threads:[~2004-02-04 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-04 20:23 Oliver Dain
2004-02-04 21:30 ` Richard B. Johnson [this message]
2004-02-04 21:48 ` odain2
2004-02-04 22:29 ` Richard B. Johnson
2004-02-04 23:34 ` Greg KH
2004-02-05 12:42 ` Richard B. Johnson
2004-02-05 15:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.53.0402041616230.3277@chaos \
--to=root@chaos.analogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=odain2@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®