From: "Richard B. Johnson" <root@chaos.analogic.com>
To: Jaco Kroon <jkroon@cs.up.ac.za>
Cc: "Ihar 'Philips' Filipau" <filia@softhome.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: stack allocation and gcc
Date: Wed, 10 Mar 2004 08:21:30 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.53.0403100806570.15421@chaos> (raw)
In-Reply-To: <404F104C.2030206@cs.up.ac.za>
The caller expects that the space for the second set of local
variables in the second program unit is not allocated until the
program unit is entered.
I don't know why he would expect this behavior. Certainly
the space for the local variables in the first program unit
is allocated at compile-time. I don't know why he would
expect that the variables in the second or subsequent
program units would be handled any differently.
I have seen this misconception before. If the caller needs
to dynamically allocate local space, dependent upon condition,
he should do something like this:
foo(....)
{
size_t len;
char buf0[SOME_SIZE];
len = strlen(buf0) + 1;
{
buf1[len]; // Second program unit buffer
}
This ends up being coded as a simple subtraction from the stack-
pointer to allocate the new space in the new program unit.
In general, the allocation for all local variables is done
at compile-time and the allocation for all globals is done
at link-time. In this context, 'allocation' means calculation
of offsets and displacements, not the allocation and relocation
that occurs when a program is executed.
On Wed, 10 Mar 2004, Jaco Kroon wrote:
> Hi Ihar,
>
> In your code you have 3 buffers, one in the mani branch of 32 bytes and
> one of 32 bytes in each of the sub branches. This adds up to a total of
> 64 bytes since as you say, the two buffers named buf2[32] can be
> shared. Thus it is 32 bytes for buf and 32 bytes for the shared
> buffer. Now if you look at the function startup code:
>
> 0: 55 push %ebp
> 1: 89 e5 mov %esp,%ebp
> 3: 83 ec 68 sub $0x68,%esp
>
> THe push saves the frame pointer (ebp). The mov sets up the new stack
> frame and the sub allocates space of 68 bytes on the stack, 4 bytes more
> than the expected 64, this is probably for temporary storage required
> somewhere in the function. As such, gcc does not allocate 32 bytes too
> many (at least not on i386, but probably not on other architectures either).
>
> Jaco
>
> Ihar 'Philips' Filipau wrote:
>
> > Hello All!
> >
> > [ please cc: me ]
> >
> > I have observed funny behaviour of both gcc 2.95/322 on ppc32 and
> > i686 platforms.
> >
> > Have written this routine and compiled it with 'gcc -O2':
> >
> > int a(int v)
> > {
> > char buf[32];
> >
> > if (v > 5) {
> > char buf2[32];
> > printf( buf, buf2 );
> > } else {
> > char buf2[32];
> > printf( buf, buf2 );
> > }
> > return 1;
> > }
> >
> > I expected that stack on every branch of 'if(v>5)' will be
> > allocated later - but seems that gcc allocate stack space once and in
> > this case it will 'overallocate' 32 bytes - 'char buf2' will be
> > allocated twice for every branch. On i686 gcc allocates 108 bytes, on
> > ppc32 it allocates 116 bytes. (additional space seems to be induced by
> > printf() call)
> > Adding to this routine something like 'do { char a[32]; }
> > while(0);' several times shows that stack buffers are not reused - and
> > allocated for every this kind of context separately.
> >
> > As to my understanding - since this buffers do live in different
> > mutually exclusive contextes - they can be reused. But this seems to
> > be not case. Waste of precious kernel stack space - and waste of d-cache.
> >
> > I have read 'info gcc' - but found nothing relevant to this.
> > I've checked ppc abi - but found no limitations to reuse of stack
> > space.
> >
> > Is it expected behaviour of compiler? gcc feature?
> >
> > [ I have created macro which opens into inline function call which
> > utilizes va_list - on ppc32 va_list adds at least 32 bytes to stack
> > use. Seems to be bad idea for kernel-space, since every use if macro
> > adds to stack use (10 macro calls == 320 bytes). Easy to rewrite to
> > not to use va_list - but have I *NO* stack allocation check script in
> > place - this stuff could easily get into production release. Not nice. ]
> >
> > disassembling outputs:
> >
> ===========================================
> This message and attachments are subject to a disclaimer. Please refer to www.it.up.ac.za/documentation/governance/disclaimer/ for full details.
> Hierdie boodskap en aanhangsels is aan 'n vrywaringsklousule onderhewig. Volledige besonderhede is by www.it.up.ac.za/documentation/governance/disclaimer/ beskikbaar.
> ===========================================
>
>
Cheers,
Dick Johnson
Penguin : Linux version 2.4.24 on an i686 machine (797.90 BogoMips).
Note 96.31% of all statistics are fiction.
next prev parent reply other threads:[~2004-03-10 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-10 12:27 Ihar 'Philips' Filipau
2004-03-10 12:55 ` Jaco Kroon
2004-03-10 13:15 ` Bart Hartgers
2004-03-10 13:21 ` Richard B. Johnson [this message]
2004-03-10 15:05 ` Ihar 'Philips' Filipau
2004-03-11 6:04 ` IBM Thinkpad with docking station Frank Fiene
2004-03-10 14:25 ` stack allocation and gcc Ihar 'Philips' Filipau
[not found] ` <200403101344.37171.baldrick@free.fr>
2004-03-10 14:06 ` Ihar 'Philips' Filipau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.53.0403100806570.15421@chaos \
--to=root@chaos.analogic.com \
--cc=filia@softhome.net \
--cc=jkroon@cs.up.ac.za \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®