mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Richard B. Johnson" <root@chaos.analogic.com>
To: Frank van Maarseveen <frankvm@xs4all.nl>
Cc: Jesse Pollard <jesse@cats-chateau.net>,
	Torin Ford <code-monkey@qwest.net>,
	Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.x Fork Problem?
Date: Fri, 13 Aug 2004 15:36:34 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.53.0408131521550.26183@chaos> (raw)
In-Reply-To: <20040813190958.GB18563@janus>

On Fri, 13 Aug 2004, Frank van Maarseveen wrote:

> On Thu, Aug 12, 2004 at 09:26:27AM -0500, Jesse Pollard wrote:
> > On Wednesday 11 August 2004 19:01, Torin Ford wrote:
> > >
> > > pid = fork();
> > > switch (pid)
> > > {
> > >    case -1:
> > >       blah; /* big trouble */
> > >       break;
> > >    case 0: /* Child */
> > >       exit(1);
> > >       break;
> > >    default: /* Parent */
> > >       pid2 = waitpid(pid, &status, 0);
> > >       if (pid2 == -1)
> > >       {
> > >          blah;  /* check out errno */
> > >       }
> > > }
> >
> > Yup - the parent process executed waitpid before the child process finished
> > the setup. This can happen in a multi-cpu environment or even a single, if
> > the scheduler puts the parent process higher than the child in the queue.
>
> ugh! I can follow the rationale for SMP.
>
> But wouldn't this kind of behavior actually break most real world programs?
>
> --
> Frank

When fork() returns with a pid. The pid is valid. It cannot
be that the child doesn't exist yet. This would, as you said,
break everything. What seems to happening is the child calls
exit() before the parent gets the CPU. The child should wait
in exit() until somebody claims its status.

There has never been any guarantee that the child gets the CPU
sooner than the parent. If the parent and child need to synchronize
things, there are lots of ways to do it.

In the above code there is something missing. in the code shown,
the child __will__ wait in exit() until somebody claims its status.
However, the child probably did a setsid(), becoming a process-leader
or the parent set up a SIGCHLD handler before the fork. In these
cases, the exit() will quickly exit because somebody will claim
the exit status.

So, by the time the parent gets the CPU, the child is long gone.
The solution is to use the default SIGCHLD handler if the parent
expects to get the child's status and for the child to not execute
setsid(), which will allow init to reap its status.

Cheers,
Dick Johnson
Penguin : Linux version 2.4.26 on an i686 machine (5570.56 BogoMips).
            Note 96.31% of all statistics are fiction.



  reply	other threads:[~2004-08-13 19:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-12  0:01 Torin Ford
2004-08-12 12:08 ` Alan Cox
2004-08-12 14:26 ` Jesse Pollard
2004-08-13 19:09   ` Frank van Maarseveen
2004-08-13 19:36     ` Richard B. Johnson [this message]
2004-08-13 20:06       ` Frank van Maarseveen
2004-08-13 22:50         ` Torin Ford
2004-08-13 22:07     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.53.0408131521550.26183@chaos \
    --to=root@chaos.analogic.com \
    --cc=code-monkey@qwest.net \
    --cc=frankvm@xs4all.nl \
    --cc=jesse@cats-chateau.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®