mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Richard B. Johnson" <root@chaos.analogic.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Srinivas G." <srinivasg@esntechnologies.co.in>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Having problem with mmap system call!!!
Date: Thu, 16 Sep 2004 14:13:29 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.53.0409161404001.13362@chaos> (raw)
In-Reply-To: <1095350240.22750.37.camel@localhost.localdomain>

On Thu, 16 Sep 2004, Alan Cox wrote:

> On Iau, 2004-09-16 at 15:54, Richard B. Johnson wrote:
> > > SHM_FAIL is the wrong error check btw.
> > >
> >
> > MAP_FAILED only appeared in real late 'C' runtime library headers.
> > That's why the code defines SHM_FAIL, which is also correct, but
> > doesn't cause a redefinition error.
>
> SuS doesn't permit the use of SHM_FAIL. And you don't get redefinition
> errors if you use ds
>
> > Well that's really nice. Now, how do you do that? The kernel DS
> > is not the user DS so you end up with a kernel hack instead of
> > a user hack?
>
> Who cares about DS ? the user space page tables get mapped, its how all
> mmap functions work. A simple example is the sound drivers (2.4
> drivers/sound) which kmalloc a buffer of kernel space then make it
> mappable to the user
>

Alan,
Here is some code from a video driver.

static int vino_mmap(struct file *file, struct vm_area_struct *vma)
{
	struct video_device *dev = video_devdata(file);
	struct vino_device *v = dev->priv;
	unsigned long start = vma->vm_start;
	unsigned long size  = vma->vm_end - vma->vm_start;
	int i, err = 0;

	if (down_interruptible(&v->sem))
		return -EINTR;
	if (size > v->page_count * PAGE_SIZE) {
		err = -EINVAL;
		goto out;
	}
	for (i = 0; i < v->page_count; i++) {
		unsigned long page = virt_to_phys((void *)v->desc[i]);
		if (remap_page_range(start, page, PAGE_SIZE, PAGE_READONLY)) {
			err = -EAGAIN;
			goto out;
		}
		start += PAGE_SIZE;
		if (size <= PAGE_SIZE) break;
		size -= PAGE_SIZE;
	}
out:
	up(&v->sem);
	return err;

}

I deliberately used this as a sample so you can't say what
you usually say... Anyway are you aware that ...

	unsigned long size  = vma->vm_end - vma->vm_start;

... ends up being 32 bytes longer than the length the user-mode
code put into mmap()?

That's why I use a driver ioctl() to return the physical address
and the length so user-mode code can mmap() without the hassle
of "optimizations" (read kernel bugs) mucking with buffers,
especially those then end up overlapping because of bugs like
above.

Now, if somebody is having trouble with mmap(), it is quite
a bit better I believe, to reduce the basic user-mode mem-mapping
to its lowest common denominator. Therefore, I showed what was
guaranteed to work.

Cheers,
Dick Johnson
Penguin : Linux version 2.4.26 on an i686 machine (5570.56 BogoMips).
            Note 96.31% of all statistics are fiction.


  reply	other threads:[~2004-09-16 18:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4EE0CBA31942E547B99B3D4BFAB348111078FE@mail.esn.co.in>
2004-09-16 14:07 ` Richard B. Johnson
2004-09-16 13:31   ` Alan Cox
2004-09-16 14:54     ` Richard B. Johnson
2004-09-16 15:57       ` Alan Cox
2004-09-16 18:13         ` Richard B. Johnson [this message]
2004-09-16 20:01           ` Alan Cox
2004-09-16 14:42 Srinivas G.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.53.0409161404001.13362@chaos \
    --to=root@chaos.analogic.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivasg@esntechnologies.co.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®