Re: [PATCH] Fix V.110 on HiSax HFC_PCI.

[Marcelo Tosatti <marcelo@conectiva.com.br>]

On Tue, 29 Apr 2003, Kai Germaschewski wrote:

> On Tue, 29 Apr 2003, David Woodhouse wrote:
>
> > This patch fixes V.110 dialin to HFC_PCI ISDN adapters, which weren't
> > sending V.110 idle frames correctly before due to missing wakeups from
> > the low-level driver.
> >
> > This is for 2.4 only -- 2.5 with ISDN doesn't even boot for me at the moment.
> >
> > --- drivers/isdn/hisax/hfc_pci.c.orig	2003-04-26 00:19:36.000000000 +0100
> > +++ drivers/isdn/hisax/hfc_pci.c	2003-04-26 00:19:43.000000000 +0100
> > @@ -687,6 +687,10 @@
> >  				debugl1(cs, "hfcpci_fill_fifo_trans %d frame length %d discarded",
> >  					bcs->channel, bcs->tx_skb->len);
> >
> > +			if (bcs->st->lli.l1writewakeup &&
> > +                           (PACKET_NOACK != bcs->tx_skb->pkt_type))
> > +				bcs->st->lli.l1writewakeup(bcs->st, bcs->tx_skb->len);
> > +
> >  			dev_kfree_skb_any(bcs->tx_skb);
> >  			cli();
> >  			bcs->tx_skb = skb_dequeue(&bcs->squeue);	/* fetch next data */
> >
>
> Thanks, this looks fine. I'll merge it if Marcelo doesn't take it right
> away (please do ;)

Done.

Thanks.