From: Davide Libenzi <davidel@xmailserver.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Winischhofer <thomas@winischhofer.net>
Subject: Re: [patch] SiS IRQ router 96x detection ...
Date: Tue, 3 Jun 2003 07:30:26 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.55.0306030726150.4125@bigblue.dev.mcafeelabs.com> (raw)
In-Reply-To: <1054644033.9234.6.camel@dhcp22.swansea.linux.org.uk>
On Tue, 3 Jun 2003, Alan Cox wrote:
> On Maw, 2003-06-03 at 07:06, Davide Libenzi wrote:
> > Thanks to Thomas we now know how to detect the 96x SiS SB. The patch
> > against 2.4.20 uses the documentated method to use the correct router
> > function and hence make new SiS chipsets to work with the new USB routing
> > registers. Tested and working fine on my machine.
>
> > + { "PIIX", PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371FB_0, pirq_piix_get, pirq_piix_set, NULL },
> > + { "PIIX", PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371SB_0, pirq_piix_get, pirq_piix_set, NULL },
>
> The NULL is implied so you don't need to mash every entry in the table..
I know is implied Alan, but you either use the std ".field = xxx" or you
fill out members. Otherwise the next one eventually extending the table
might find himself screwed. Or you use a macro to initialize each member.
- Davide
prev parent reply other threads:[~2003-06-03 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-03 6:06 Davide Libenzi
2003-06-03 12:40 ` Alan Cox
2003-06-03 14:30 ` Davide Libenzi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.55.0306030726150.4125@bigblue.dev.mcafeelabs.com \
--to=davidel@xmailserver.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®