From: Marcelo Tosatti <marcelo@conectiva.com.br>
To: Chris Mason <mason@suse.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrea Arcangeli <andrea@suse.de>,
Nick Piggin <piggin@cyberone.com.au>
Subject: Re: Status of the IO scheduler fixes for 2.4
Date: Fri, 4 Jul 2003 17:01:54 -0300 (BRT) [thread overview]
Message-ID: <Pine.LNX.4.55L.0307041639020.7389@freak.distro.conectiva> (raw)
In-Reply-To: <1057197726.20903.1011.camel@tiny.suse.com>
On Wed, 2 Jul 2003, Chris Mason wrote:
> On Wed, 2003-07-02 at 18:28, Marcelo Tosatti wrote:
> > On Wed, 2 Jul 2003, Marcelo Tosatti wrote:
> >
> > >
> > > Hello people,
> > >
> > > What is the status of the IO scheduler fixes for increased fairness for
> > > 2.4 ?
> > >
> > > I haven't had time to read and think about everything you guys discussed,
> > > so a brief summary would be very helpful for me.
> > >
> > > Danke
> >
> > Ah, we all want that the fairness issues to be fixed in 2.4.22, right ?
>
> My current code is attached, it's basically a merge of these 3 patches,
> with modifications based on benchmarks and latency measurements here.
>
> fix_pausing: From Andrea, it fixes a few corner case races where
> wakeups can be missed in wait_on_buffer, wait_on_page, and
> __get_request_wait.
>
> elevator-low-latency: From Andrea, it keeps the amount of io on a given
> queue to a reasonable number. This prevents a small number of huge
> requests from introducing large latencies on smaller requests.
>
> q->full: From Nick, it reduces latency in __get_request_wait by making
> sure new io can't come in and steal requests before old waiters are
> served.
>
> Those represent the big 3 areas I believe the latencies are coming
> from. The q->full patch can hurt throughput badly as the number of
> writers increases (50% of what 2.4.21 gets for 10 or more concurrent
> streaming writers), but it really seems to help desktop workloads here.
Chris,
Would you please separate those tree fixes in separate diffs?
For me it seems low latency and fix-pausing patches should be enough for
"better" IO fairness. I might be wrong about that, though.
Lets try this: Include elevator-low-latency in -pre3 (which I'm trying to
release today), then fix pausing in -pre4. If the IO fairness still doesnt
get somewhat better for general use (well get isolated user reports and
benchmarks for both the two patches), then I might consider the q->full
patch (it has throughtput drawbacks and I prefer avoiding a tunable
there).
Sounds good?
next prev parent reply other threads:[~2003-07-04 19:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 22:26 Marcelo Tosatti
2003-07-02 22:28 ` Marcelo Tosatti
2003-07-03 2:02 ` Chris Mason
2003-07-03 10:58 ` Stephan von Krawczynski
2003-07-03 12:01 ` Chris Mason
2003-07-03 12:07 ` Marc-Christian Petersen
2003-07-03 12:28 ` Stephan von Krawczynski
2003-07-03 12:31 ` Marc-Christian Petersen
2003-07-03 13:11 ` Chris Mason
2003-07-04 20:01 ` Marcelo Tosatti [this message]
2003-07-04 21:37 ` Chris Mason
2003-07-05 0:05 ` Andrea Arcangeli
2003-07-05 0:47 ` Chris Mason
2003-07-05 1:04 ` Andrea Arcangeli
2003-07-06 7:58 ` Marc-Christian Petersen
2003-07-06 18:51 ` Chris Mason
2003-07-07 4:06 ` Nick Piggin
2003-07-05 0:00 ` Andrea Arcangeli
2003-07-05 15:59 ` Marcelo Tosatti
2003-07-05 16:36 ` Andrea Arcangeli
2003-07-03 18:07 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.55L.0307041639020.7389@freak.distro.conectiva \
--to=marcelo@conectiva.com.br \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®