From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Mark Gross <mgross@linux.co.intel.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SMP signal latency fix up.
Date: Fri, 7 Nov 2003 16:17:29 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.56.0311071610320.29925@earth> (raw)
In-Reply-To: <Pine.LNX.4.44.0311070701370.1842-100000@home.osdl.org>
On Fri, 7 Nov 2003, Linus Torvalds wrote:
> (It _looks_ obvious enough, but can you check that there are no pointers
> that we might be following in the "is it running" checks that could be
> stale because we don't hold the runqueue lock any more).
the 'is it running' check is 'task_curr(p)', which in this circumstance is
equivalent to the following test:
per_cpu(runqueues, (cpu)).curr == p
where 'cpu' is p->thread_info->cpu. All pointers dereferenced in this test
are stable, because 1) send_signal() is always called within the siglock,
which serializes with task exit 2) p->thread_info->cpu is always valid for
the same reason.
so this seems to be safe to me.
Ingo
next prev parent reply other threads:[~2003-11-07 22:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-06 22:49 Mark Gross
2003-11-06 23:20 ` Linus Torvalds
2003-11-07 1:39 ` Mark Gross
2003-11-07 1:42 ` Mark Gross
2003-11-07 9:45 ` Ingo Molnar
2003-11-07 15:43 ` Mark Gross
2003-11-07 9:39 ` Ingo Molnar
2003-11-07 15:09 ` Linus Torvalds
2003-11-07 15:17 ` Ingo Molnar [this message]
2003-11-07 15:31 ` Ingo Molnar
2003-11-07 15:29 ` Ingo Molnar
2003-11-07 17:03 ` Mark Gross
2003-11-08 6:48 ` Ingo Molnar
2003-11-06 23:26 ` Chris Friesen
2003-11-06 23:35 ` Mark Gross
2003-11-07 0:55 ` Nuno Silva
2003-11-07 10:24 ` Ingo Molnar
2003-11-06 23:00 Mark Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.56.0311071610320.29925@earth \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.co.intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®