From: Naveen Gupta <ngupta@google.com>
To: wim@iguana.be, david@2gen.com, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset
Date: Mon, 15 Aug 2005 14:21:05 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.56.0508151416530.27145@krishna.corp.google.com> (raw)
This patch sets the WDT_ENABLE bit of the Lock Register to enable the
watchdog and WDT_LOCK bit only if nowayout is set. The old code always
sets the WDT_LOCK bit of watchdog timer for Intel 6300ESB chipset. So, we
end up locking the watchdog instead of enabling it.
Signed-off-by: Naveen Gupta <ngupta@google.com>
Index: linux-2.6.12/drivers/char/watchdog/i6300esb.c
===================================================================
--- linux-2.6.12.orig/drivers/char/watchdog/i6300esb.c 2005-08-15 11:19:01.000000000 -0700
+++ linux-2.6.12/drivers/char/watchdog/i6300esb.c 2005-08-15 11:21:35.000000000 -0700
@@ -97,7 +97,7 @@
u8 val;
/* Enable or Enable + Lock? */
- val = 0x02 | nowayout ? 0x01 : 0x00;
+ val = 0x02 | (nowayout ? 0x01 : 0x00);
pci_write_config_byte(esb_pci, ESB_LOCK_REG, val);
}
next reply other threads:[~2005-08-15 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-15 21:21 Naveen Gupta [this message]
2005-08-15 22:11 ` David Härdeman
2005-08-15 22:17 ` Naveen Gupta
2005-08-15 22:27 ` David Härdeman
2005-08-16 6:03 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.56.0508151416530.27145@krishna.corp.google.com \
--to=ngupta@google.com \
--cc=akpm@osdl.org \
--cc=david@2gen.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®