mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Mikko Korhonen <mjkorhon@aeropc5.hut.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: irda weirdness
Date: Mon, 6 Oct 2003 00:51:28 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0310060046410.30384@gw.localnet> (raw)
In-Reply-To: <3F8008E1.1080200@aeropc5.hut.fi>

Not sure about this but I think the problem might lie in ircomm_tty_write:

        spin_lock_irqsave(&self->spinlock, flags);
...
                /* Copy data */
                if (from_user)
                        copy_from_user(skb_put(skb,size), buf+len, size);
                else
                        memcpy(skb_put(skb,size), buf+len, size);
...
        spin_unlock_irqrestore(&self->spinlock, flags);

asm/uaccess.h:498 is might_sleep() in copy_from_user() in my tree so this
might be it. No fix though, I just noticed this bug some time ago and
completly forgot about it until now.

Regards,
Patrick

On Sun, 5 Oct 2003, Mikko Korhonen wrote:

>     Hi,
>
> I'm getting
> Debug: sleeping function called from invalid context at
> include/asm/uaccess.h:498
> and
> Badness in local_bh_enable at kernel/softirq.c:119
>  (look below) with plain 2.6.0-test6 and sir_dev ircomm_tty (as well as
> with other 2.6.0-tests).
>
> Mikko
>
>

  parent reply	other threads:[~2003-10-05 22:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-05 12:04 Mikko Korhonen
2003-10-05 15:36 ` Martin Diehl
2003-10-05 22:51 ` Patrick McHardy [this message]
2003-10-06  6:16   ` Martin Diehl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0310060046410.30384@gw.localnet \
    --to=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjkorhon@aeropc5.hut.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®