From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
lhcs-devel@lists.sourceforge.net
Subject: Re: kernel BUG at kernel/exit.c:792!
Date: Wed, 3 Dec 2003 21:03:09 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.58.0312032100100.4424@earth> (raw)
In-Reply-To: <Pine.LNX.4.58.0312030748240.5258@home.osdl.org>
On Wed, 3 Dec 2003, Linus Torvalds wrote:
> I think the problem is the BUG() itself, not really the caller. So I'd
> prefer the fix for this to be to just entirely remove the debug tests
> withing that "#ifdef CONFIG_SMP", rather than hide the threads from
> /proc when this happens.
>
> Ingo, comments?
i'd like to keep the BUG() - it has caught this bug, and it has caught
other bugs too in the past. The next_thread() use of procfs is clearly
illegal if it happens after a thread has been removed from the tasklist.
procfs is really special in this regard (nothing else that accesses the
thread list is supposed to have a stale reference to the task).
removing the debug tests will cause further crashes i think - the thread
pointers are not valid anymore, they could point to truly freed tasks.
(this particular task is not freed yet because it has a procfs reference -
but the thread list pointers are not valid anymore.)
Ingo
next prev parent reply other threads:[~2003-12-03 20:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-03 10:08 Srivatsa Vaddagiri
[not found] ` <3FCDCEA3.1020209@mailandnews.com>
2003-12-03 12:53 ` Srivatsa Vaddagiri
2003-12-03 17:46 ` Manfred Spraul
2003-12-03 17:52 ` Manfred Spraul
2003-12-03 18:19 ` Linus Torvalds
2003-12-03 19:58 ` Ingo Molnar
2003-12-03 19:59 ` Ingo Molnar
2003-12-03 20:08 ` Linus Torvalds
2003-12-03 20:18 ` Ingo Molnar
2003-12-03 20:19 ` Manfred Spraul
2003-12-03 20:26 ` Ingo Molnar
2003-12-03 20:31 ` Ingo Molnar
2003-12-03 20:55 ` Linus Torvalds
2003-12-03 20:35 ` Ingo Molnar
2003-12-03 15:51 ` Linus Torvalds
2003-12-03 20:03 ` Ingo Molnar [this message]
2003-12-03 20:09 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0312032100100.4424@earth \
--to=mingo@elte.hu \
--cc=lhcs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®