From: Roman Zippel <zippel@linux-m68k.org>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] v4l-05 add infrared remote support
Date: Thu, 15 Jan 2004 15:26:02 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.58.0401151502320.27223@serv> (raw)
In-Reply-To: <20040115115611.GA16266@bytesex.org>
Hi,
On Thu, 15 Jan 2004, Gerd Knorr wrote:
> diff -u linux-2.6.1/drivers/media/Kconfig linux/drivers/media/Kconfig
> --- linux-2.6.1/drivers/media/Kconfig 2004-01-14 15:05:10.000000000 +0100
> +++ linux/drivers/media/Kconfig 2004-01-14 15:09:35.000000000 +0100
> @@ -49,5 +49,11 @@
> default VIDEO_BT848
> depends on VIDEO_DEV
>
> +config VIDEO_IR
> + tristate
> + default y if VIDEO_BT848=y || VIDEO_SAA7134=y
> + default m if VIDEO_BT848=m || VIDEO_SAA7134=m
> + depends on VIDEO_DEV
> +
> endmenu
>
This can also be written as:
config VIDEO_IR
def_tristate VIDEO_BT848 || VIDEO_SAA7134
def_tristate is the same as tristate & default ...
The dependency is redundant as the other options already depend on it.
Another possibility is to use select:
# selected as needed
config VIDEO_IR
tristate
config VIDEO_BT848
...
select VIDEO_IR
This has the advantage that adding/removing drivers only requires changes
at a single place.
bye, Roman
next prev parent reply other threads:[~2004-01-15 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 11:56 Gerd Knorr
2004-01-15 14:26 ` Roman Zippel [this message]
2004-01-15 15:20 ` Gerd Knorr
2004-01-15 16:32 ` Roman Zippel
2004-01-20 1:55 ` Rusty Russell
2004-01-20 9:30 ` Gerd Knorr
2004-01-20 12:44 ` [patch] new module args for ir-kbd-*.c Gerd Knorr
2004-01-21 0:26 ` [patch] v4l-05 add infrared remote support Rusty Russell
2004-01-21 3:49 ` Rusty Russell
2004-01-21 9:59 ` Gerd Knorr
2004-01-22 1:05 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0401151502320.27223@serv \
--to=zippel@linux-m68k.org \
--cc=akpm@osdl.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®