From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264534AbUBQJiH (ORCPT ); Tue, 17 Feb 2004 04:38:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264537AbUBQJiG (ORCPT ); Tue, 17 Feb 2004 04:38:06 -0500 Received: from dragnfire.mtl.istop.com ([66.11.160.179]:57284 "EHLO hemi.commfireservices.com") by vger.kernel.org with ESMTP id S264534AbUBQJiF (ORCPT ); Tue, 17 Feb 2004 04:38:05 -0500 Date: Tue, 17 Feb 2004 04:37:45 -0500 (EST) From: Zwane Mwaikambo To: Rusty Russell Cc: Linux Kernel , Andrew Morton , lhcs-devel@lists.sourceforge.net, Pavel Machek Subject: Re: [PATCH][2.6-mm] split drain_local_pages In-Reply-To: <20040217073038.33DA62C594@lists.samba.org> Message-ID: References: <20040217073038.33DA62C594@lists.samba.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Feb 2004, Rusty Russell wrote: > In message you write: > > CPU hotplug core needs to pass a cpu parameter to drain_local_pages, it's > > safe to call __drain_local_pages if the cpu being drained is offline. The > > semantics for drain_local_pages do not change. > > I prefer this version: it gets the #ifdef correct too. Indeed, i favour your version too.