Re: [Lksctp-developers] Re: [PATCH] net/sctp/Config.in make oldconfig compatibility (bash)

[Sridhar Samudrala <sri@us.ibm.com>]

On Tue, 17 Feb 2004, David S. Miller wrote:

> On Tue, 17 Feb 2004 10:48:55 -0800 (PST)
> Sridhar Samudrala <sri@us.ibm.com> wrote:
>
> > I thought SCTP changes were backed out just because of these 'make oldconfig'
> > errors from the 2.4 tree.
>
> I believe Marcelo is just going to clone a tree right before he took in the
> SCTP stuff, in order to do the 2.4.25 release.  Then for 2.4.26-pre1 he'll
> take the SCTP changes back in and we can add the fix.
>
> > Anyway, i have submitted the attached patch that should fix this to davem.
> > 'make oldconfig' and 'make menuconfig' worked fine after applying this patch.
>
> I believe this space fix here is necessary as well as your crypto changes
> Sridhar.

If you are referring to the space before the ] brackets in the if statements,
-  if [ "$CONFIG_CRYPTO_MD5" = "n" -a "$CONFIG_CRYPTO_SHA1" = "n"]; then
+  if [ "$CONFIG_CRYPTO_MD5" = "n" -a "$CONFIG_CRYPTO_SHA1" = "n" ]; then

those lines are no longer there in the SCTP Config.in with the crypto changes
patch.

The other space introduced in Matthias patch is in the following lines.
-        choice 'SCTP: Cookie HMAC Algorithm' \
+        choice '    SCTP: Cookie HMAC Algorithm' \

I am not sure if this is needed.

Thanks
Sridhar