From: Zwane Mwaikambo <zwane@linuxpower.ca>
To: "Nguyen, Tom L" <tom.l.nguyen@intel.com>
Cc: Andreas Schwab <schwab@suse.de>,
greg@kroah.com, linux-kernel@vger.kernel.org, "Nakajima,
Jun" <jun.nakajima@intel.com>, "Luck, Tony" <tony.luck@intel.com>
Subject: RE: [PATCH]2.6.3-rc2 MSI Support for IA64
Date: Fri, 20 Feb 2004 20:55:26 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.58.0402202054050.7734@montezuma.fsmlabs.com> (raw)
In-Reply-To: <C7AB9DA4D0B1F344BF2489FA165E5024040580FB@orsmsx404.jf.intel.com>
On Fri, 20 Feb 2004, Nguyen, Tom L wrote:
> Friday, Feb. 20, 2004 8:55 AM, Andreas Schwab wrote:
>
> >> @@ -316,6 +310,19 @@
> >> return current_vector;
> >> }
> >>
> >> +int ia64_alloc_vector(void)
> >> +{
> >> + static int next_vector = IA64_FIRST_DEVICE_VECTOR;
> >> +
> >> + if (next_vector > IA64_LAST_DEVICE_VECTOR)
> >> + /* XXX could look for sharable vectors instead of panic'ing... */
> >> + panic("ia64_alloc_vector: out of interrupt vectors!");
> >> +
> >> + nr_alloc_vectors++;
> >> +
> >> + return next_vector++;
> >> +}
> >> +
>
> > IMHO this should be CONFIG_IA64 only.
>
> To avoid some #ifdef statements as possible, "ia64_platform"
> defined in the header file "msi.h" is set to TRUE only if
> setting CONFIG_IA64 to 'Y'. The setting of ia64_platform
> to TRUE will execute function ia64_alloc_vector.
>
> This API is only used in assign_msi_vector()in msi.c:
>
> vector = (ia64_platform ? ia64_alloc_vector() :
> assign_irq_vector(MSI_AUTO));
I think we should just come up with a standard name here, i'm biased and
think it should be assign_irq_vector ;)
next prev parent reply other threads:[~2004-02-21 1:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-20 18:36 Nguyen, Tom L
2004-02-20 18:58 ` Mika Penttilä
2004-02-20 19:05 ` David Mosberger
2004-02-21 1:55 ` Zwane Mwaikambo [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-02-23 16:44 Nguyen, Tom L
2004-02-20 19:38 Nguyen, Tom L
2004-02-20 19:31 Nguyen, Tom L
2004-02-20 19:43 ` Mika Penttilä
2004-02-20 17:47 long
2004-02-20 16:54 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0402202054050.7734@montezuma.fsmlabs.com \
--to=zwane@linuxpower.ca \
--cc=greg@kroah.com \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
--cc=tom.l.nguyen@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®