From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261602AbUBUS6H (ORCPT ); Sat, 21 Feb 2004 13:58:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261604AbUBUS6H (ORCPT ); Sat, 21 Feb 2004 13:58:07 -0500 Received: from fw.osdl.org ([65.172.181.6]:37026 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261603AbUBUS6F (ORCPT ); Sat, 21 Feb 2004 13:58:05 -0500 Date: Sat, 21 Feb 2004 11:03:17 -0800 (PST) From: Linus Torvalds To: "Eric W. Biederman" cc: Pavel Machek , Stephen Hemminger , ak@suse.de, linux-kernel@vger.kernel.org Subject: Re: kernel/microcode.c error from new 64bit code In-Reply-To: Message-ID: References: <20040218145218.6bae77b5@dell_ss3.pdx.osdl.net> <20040221141608.GB310@elf.ucw.cz> <20040221173449.GA277@elf.ucw.cz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 21 Feb 2004, Eric W. Biederman wrote: > > What is wrong with the original? > > - wrmsr(MSR_IA32_UCODE_WRITE, (unsigned int)(uci->mc->bits), 0); > > I don't see how anything else could be correct. Did you miss the fact that we now support x86-64, and that if compiled that way the address is 64-bit? Linus