mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	arjanv@redhat.com, davej@redhat.com, Ingo Molnar <mingo@elte.hu>
Subject: Re: raid 5 with >= 5 members broken on x86
Date: Thu, 26 Feb 2004 14:32:37 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0402261426460.7830@ppc970.osdl.org> (raw)
In-Reply-To: <or1xohpjzn.fsf@free.redhat.lsd.ic.unicamp.br>



On Thu, 26 Feb 2004, Alexandre Oliva wrote:
> 
> There's a reason why I added both asms, one with volatile and one
> without.  I know what I'm doing.  I even tried to explain it in the
> comments.  Did you read them?  Let me try again.

Ok, I'll buy it.

> > There is nothing to say that gcc wouldn't do a re-load or something
> > in between, so you really need to tell the _first_ ask about it.
> 
> The only other reload it could do is an input reload of p4 and p5,
> which, again, doesn't matter, because p4 and p5 are dead anyway.

Ok. That's the missing piece. The thing is wrong, but we don't care, 
because even if gcc saves the old values for some silly reload, they're 
dead and uninteresting.

Ok. I did the silly one-liner, but if the "don't care" approach really 
improves code generation, feel free to send one that fixes both the P5 and 
PII cases..

		Linus

  reply	other threads:[~2004-02-26 22:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-26 18:36 Alexandre Oliva
2004-02-26 21:50 ` Linus Torvalds
2004-02-26 22:04   ` Linus Torvalds
2004-02-26 22:13   ` Alexandre Oliva
2004-02-26 22:32     ` Linus Torvalds [this message]
2004-02-26 22:40       ` Alexandre Oliva
2004-02-26 22:57       ` Alexandre Oliva
2004-02-26 23:37       ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0402261426460.7830@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=akpm@osdl.org \
    --cc=aoliva@redhat.com \
    --cc=arjanv@redhat.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®