From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261292AbUBZXz6 (ORCPT ); Thu, 26 Feb 2004 18:55:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261302AbUBZXz5 (ORCPT ); Thu, 26 Feb 2004 18:55:57 -0500 Received: from e31.co.us.ibm.com ([32.97.110.129]:3731 "EHLO e31.co.us.ibm.com") by vger.kernel.org with ESMTP id S261292AbUBZXzx (ORCPT ); Thu, 26 Feb 2004 18:55:53 -0500 Date: Thu, 26 Feb 2004 15:53:58 -0800 (PST) From: Sridhar Samudrala X-X-Sender: sridhar@localhost.localdomain To: Adrian Bunk cc: Marcelo Tosatti , netdev@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: 2.4.26-pre1: SCTP compile error In-Reply-To: <20040226212759.GV5499@fs.tum.de> Message-ID: References: <20040226212759.GV5499@fs.tum.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Feb 2004, Adrian Bunk wrote: > On Wed, Feb 25, 2004 at 04:09:20PM -0300, Marcelo Tosatti wrote: > >... > > It contains a big SCTP merge (to match 2.6 API), networking updates, > >... > > I got the compile error forwarded below using gcc 2.95.3 . > > cu > Adrian > > > > ... > gcc-2.95 -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.26-pre1-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -nostdinc -iwithprefix include -DKBUILD_BASENAME=ipv6 -c -o ipv6.o ipv6.c > In file included from ipv6.c:77: > /home/bunk/linux/kernel-2.4/linux-2.4.26-pre1-full/include/net/sctp/sctp.h:119: warning: `MSECS_TO_JIFFIES' redefined > /home/bunk/linux/kernel-2.4/linux-2.4.26-pre1-full/include/net/irda/irda.h:89: warning: this is the location of the previous definition I missed this warning as i don't have irda enabled in my config. A simple fix would be to rename the macro in sctp.h to SCTP_MSECS_TO_JIFFIES. > ipv6.c: In function `sctp_v6_xmit': > ipv6.c:189: request for member `in6_u' in something not a structure or union > ipv6.c:189: request for member `in6_u' in something not a structure or union I am not seeing these errors with either gcc3.2.2 or gcc2.96. But, looking at the code, this definitely seems to be a problem. Not sure why the newer versions of gcc didn't catch them. looks like while backporting from 2.6, i missed the fact that in 2.4, fl6_src, fl6_dst in struct flowi are pointers to struct in6_addr. I will work on a patch to fix these issues shortly. Thanks Sridhar