From: Linus Torvalds <torvalds@osdl.org>
To: "Wojciech 'Sas' Cieciwa" <cieciwa@alpha.zarz.agh.edu.pl>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] ppc32: macserial.c missing variable declaration
Date: Tue, 2 Mar 2004 14:35:47 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0403021434040.3000@ppc970.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58L.0403030014530.30738@alpha.zarz.agh.edu.pl>
On Wed, 3 Mar 2004, Wojciech 'Sas' Cieciwa wrote:
> {
> struct mac_serial * info = (struct mac_serial *)tty->driver_data;
> unsigned char control, status;
> + unsigned int cmd;
> unsigned long flags;
>
> #ifdef CONFIG_KGDB
This can't be right. Those variables are never initialized anywhere.
The usage of 'cmd' should either be removed entirely, or it should be
passed in as an argument, it looks like. In the meantime, it's better to
have code that doesn't compile than code that compiles but can't possibly
do anything sane.
Linus
next prev parent reply other threads:[~2004-03-02 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 21:30 [PATCH] ppc32: Fix crash on load in DACA sound driver Benjamin Herrenschmidt
2004-03-02 23:17 ` [PATCH] ppc32: macserial.c missing variable declaration Wojciech 'Sas' Cieciwa
2004-03-02 22:35 ` Linus Torvalds [this message]
2004-03-02 22:53 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0403021434040.3000@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=cieciwa@alpha.zarz.agh.edu.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®