From: Linus Torvalds <torvalds@osdl.org>
To: Brian Gerst <bgerst@didntduck.org>
Cc: Meelis Roos <mroos@linux.ee>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] PnP BIOS exception fixes
Date: Thu, 4 Mar 2004 10:53:15 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0403041051430.1047@ppc970.osdl.org> (raw)
In-Reply-To: <404769B5.7080900@quark.didntduck.org>
On Thu, 4 Mar 2004, Brian Gerst wrote:
>
> This patch fixes two errors in fixup_exception() for PnP BIOS faults:
> - Check for the correct segments used for the BIOS
> - Fix asm constraints so that EIP and ESP are properly reloaded
I'm almost certain that you should NOT use "g" as a constraint, since that
allows the address to be on the stack frame, so when we compile without
frame pointers and the compiler uses a %esp-relative thing for the branch
address, that will totally screw up when we just re-loaded %esp inside the
asm.
Can you use "r" instead, and test that it all works for you, and send an
updated patch? Or just explain why I'm wrong.
Linus
next prev parent reply other threads:[~2004-03-04 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-04 7:23 2.6.3: PnPBIOS hangs with S875WP1 BIOS Meelis Roos
2004-03-04 13:51 ` Brian Gerst
2004-03-04 14:09 ` Meelis Roos
2004-03-04 14:45 ` Brian Gerst
2004-03-04 14:58 ` Meelis Roos
2004-03-04 17:39 ` [PATCH] PnP BIOS exception fixes Brian Gerst
2004-03-04 18:53 ` Linus Torvalds [this message]
2004-03-04 18:54 ` Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0403041051430.1047@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®