mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Peter Osterlund <petero2@telia.com>
Cc: Ben Fennema <bfennema@falcon.csc.calpoly.edu>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: Linux 2.6.5-rc1
Date: Sun, 21 Mar 2004 15:21:51 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0403211520050.1106@ppc970.osdl.org> (raw)
In-Reply-To: <m2d675vmq9.fsf@p4.localdomain>



On Sun, 21 Mar 2004, Peter Osterlund wrote:
> 
> For some reason I don't understand, this makes the UDF filesystem lock
> up when I write a bunch of mp3 files to a CDRW using the packet
> writing patch. Both "cp" and pdflush get stuck in __down. Reverting
> the semaphore changes as in the patch below makes the problem go away,
> but it's probably not the right solution to re-introduce lock_kernel()
> calls.

Looks correct. It looks like memory pressure while doign write() on the 
semaphore will try to writeback dirty inodes and data, and the kernel lock 
allowed that fine, but using the inode semaphore will just deadlock, since 
the write() already holds the semaphore.

I think the prealloc stuff could probably be protected by the inode 
spinlock instead, but for now your backout patch seems to be the same 
thing to do.

			Linus

  reply	other threads:[~2004-03-21 23:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-16  5:58 Linus Torvalds
2004-03-16 16:19 ` Linux 2.6.5-rc1 (compile stats) John Cherry
2004-03-16 21:12 ` 2.6.5-rc1 SCSI + st regressions (was: Linux 2.6.5-rc1) Matthias Andree
2004-03-16 21:17   ` Matthew Wilcox
2004-03-16 21:56     ` Matthias Andree
2004-03-16 22:29       ` Matthew Wilcox
2004-03-17 20:35       ` Kai Makisara
2004-03-17 21:18         ` Kai Makisara
2004-03-17 21:43           ` Matthias Andree
2004-03-17 21:44           ` Mike Anderson
2004-03-17 22:25             ` Kai Makisara
2004-03-17 22:55               ` Greg KH
2004-03-17 23:04               ` Mike Anderson
2004-03-17 21:32         ` Matthias Andree
2004-03-18  1:45           ` Andy Isaacson
2004-03-21 22:50 ` Linux 2.6.5-rc1 Peter Osterlund
2004-03-21 23:21   ` Linus Torvalds [this message]
2004-03-16 22:38 Subodh Shrivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0403211520050.1106@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=akpm@osdl.org \
    --cc=bfennema@falcon.csc.calpoly.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petero2@telia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®