mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zwane Mwaikambo <zwane@linuxpower.ca>
To: "Protasevich, Natalie" <Natalie.Protasevich@UNISYS.com>
Cc: Andrew Morton <akpm@osdl.org>,
	"Martin J. Bligh" <mbligh@aracnet.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	LSE <lse-tech@lists.sourceforge.net>,
	Len Brown <len.brown@intel.com>
Subject: RE: [PATCH] 2.6.5- es7000 subarch update
Date: Mon, 12 Apr 2004 16:50:11 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0404121631490.18930@montezuma.fsmlabs.com> (raw)
In-Reply-To: <452548B29F0CCE48B8ABB094307EBA1C0422014D@USRV-EXCH2.na.uis.unisys.com>

On Mon, 12 Apr 2004, Protasevich, Natalie wrote:

> It is actually close to what I had in my initial patch when I posted it
> (and got in trouble with the timer IRQ0):
>
> 			...
> 			intsrc.mpc_dstirq = pin;
> 			...
> -			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)) {
> +			&& (mp_irqs[i].mpc_dstirq == intsrc.mpc_dstirq)) {
>
> This code indexes mp_irqs[] by the pin, but has a similar "miscounting"
> problem and adds a second element with the same bus irq. I think this
> code could work either way being indexed by the pin or by the bus irq, but it
> has to be fixed in either case. (As I understand, with srcbusirq it
> doesn't  work as is for much fewer people than with dstirq :)

Indeed it does, i'm beginning to wonder if the problem is in the mpparse
code for boxes such as Andrew's which get broken. Because really if we
overwrite the previous entry then this is acting very much like what the
function says it does. The only thing which i think makes things look
awkward with your patch is;

        for (i = 0; i < mp_irq_entries; i++) {
                if ((mp_irqs[i].mpc_srcbus == intsrc.mpc_srcbus)
                      && (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)) {
                        mp_irqs[i] = intsrc;
  +                     if (intsrc.mpc_srcbusirq > pin) { <=======
  +                            int j;
  +                            for (j = 0; j < i; j++)
  +                                   if (mp_irqs[j].mpc_dstirq == intsrc.mpc_dstirq)
  +                                         mp_irqs[j].mpc_irqtype = -1;
  +                     }
                        found = 1;
                        break;
                }
        }

That just happens to get boxes like Andrew's out of the path because his
only gets broken with the irq0 override.

  reply	other threads:[~2004-04-12 20:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-12 20:25 Protasevich, Natalie
2004-04-12 20:50 ` Zwane Mwaikambo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-04-19 17:30 Protasevich, Natalie
2004-04-14 16:45 Protasevich, Natalie
2004-04-13  3:44 Protasevich, Natalie
2004-04-14  4:29 ` Len Brown
     [not found] <A6974D8E5F98D511BB910002A50A6647615F888E@hdsmsx403.hd.intel.com>
2004-04-13  3:19 ` Len Brown
2004-04-12 17:00 Protasevich, Natalie
2004-04-12 17:58 ` Zwane Mwaikambo
2004-04-12 18:31   ` Zwane Mwaikambo
2004-04-06 15:08 Protasevich, Natalie
2004-04-05 16:12 Protasevich, Natalie
2004-04-06  6:30 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0404121631490.18930@montezuma.fsmlabs.com \
    --to=zwane@linuxpower.ca \
    --cc=Natalie.Protasevich@UNISYS.com \
    --cc=akpm@osdl.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lse-tech@lists.sourceforge.net \
    --cc=mbligh@aracnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®