From: Linus Torvalds <torvalds@osdl.org>
To: Dave Jones <davej@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: fix notify_change() potential null dereference.
Date: Fri, 16 Apr 2004 14:54:52 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0404161453340.3947@ppc970.osdl.org> (raw)
In-Reply-To: <20040416213743.GS20937@redhat.com>
I disagree on this one - at least with the message.
The fact is, "inode" can't be NULL. We have a BUG() check for it, but
getting a page fault would be equally effective.
Linus
On Fri, 16 Apr 2004, Dave Jones wrote:
>
> --- linux-2.6.5/fs/attr.c~ 2004-04-16 22:36:00.000000000 +0100
> +++ linux-2.6.5/fs/attr.c 2004-04-16 22:36:37.000000000 +0100
> @@ -130,7 +130,7 @@
> int notify_change(struct dentry * dentry, struct iattr * attr)
> {
> struct inode *inode = dentry->d_inode;
> - mode_t mode = inode->i_mode;
> + mode_t mode;
> int error;
> struct timespec now = CURRENT_TIME;
> unsigned int ia_valid = attr->ia_valid;
> @@ -138,6 +138,7 @@
> if (!inode)
> BUG();
>
> + mode = inode->i_mode;
> attr->ia_ctime = now;
> if (!(ia_valid & ATTR_ATIME_SET))
> attr->ia_atime = now;
>
next prev parent reply other threads:[~2004-04-16 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:37 Dave Jones
2004-04-16 21:54 ` Linus Torvalds [this message]
2004-04-16 21:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0404161453340.3947@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®