From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265193AbUELTtm (ORCPT ); Wed, 12 May 2004 15:49:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265198AbUELTtm (ORCPT ); Wed, 12 May 2004 15:49:42 -0400 Received: from x35.xmailserver.org ([69.30.125.51]:4559 "EHLO x35.xmailserver.org") by vger.kernel.org with ESMTP id S265193AbUELTtk (ORCPT ); Wed, 12 May 2004 15:49:40 -0400 X-AuthUser: davidel@xmailserver.org Date: Wed, 12 May 2004 12:49:38 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@bigblue.dev.mdolabs.com To: Ingo Molnar cc: Jeff Garzik , Greg KH , Andrew Morton , Linux Kernel Mailing List , Netdev Subject: Re: MSEC_TO_JIFFIES is messed up... In-Reply-To: <20040512193349.GA14936@elte.hu> Message-ID: References: <20040512020700.6f6aa61f.akpm@osdl.org> <20040512181903.GG13421@kroah.com> <40A26FFA.4030701@pobox.com> <20040512193349.GA14936@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 May 2004, Ingo Molnar wrote: > > * Jeff Garzik wrote: > > > >Woah, that's new. And wrong. The code in include/asm-i386/param.h that > > >says: > > > # define JIFFIES_TO_MSEC(x) (x) > > > # define MSEC_TO_JIFFIES(x) (x) > > > > > >Is not correct. Look at kernel/sched.c for verification of this :) > > > > > > Yes, that is _massively_ broken. > > why is it wrong? For HZ == 1000 it's fine, even if it'd better to explicitly make it HZ dependent and let the compiler to discard them. - Davide