From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264348AbUE3UHW (ORCPT ); Sun, 30 May 2004 16:07:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264352AbUE3UHW (ORCPT ); Sun, 30 May 2004 16:07:22 -0400 Received: from fw.osdl.org ([65.172.181.6]:65190 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S264348AbUE3UHU (ORCPT ); Sun, 30 May 2004 16:07:20 -0400 Date: Sun, 30 May 2004 13:06:53 -0700 (PDT) From: Linus Torvalds To: Adrian Bunk cc: Jeff Garzik , linux-kernel@vger.kernel.org, "Randy.Dunlap" , Danny ter Haar , wa1ter@myrealbox.com, dth@ncc1701.cistron.net, Netdev , Andrew Morton Subject: Re: [patch] Re: Gigabit Kconfig problems with yesterday's update In-Reply-To: <20040530193706.GG13111@fs.tum.de> Message-ID: References: <40B8A37D.1090802@myrealbox.com> <20040530134544.GE13111@fs.tum.de> <20040530143734.GA24627@dth.net> <20040530094120.61b22d2e.rddunlap@osdl.org> <40BA1F25.4080402@pobox.com> <20040530193706.GG13111@fs.tum.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 30 May 2004, Adrian Bunk wrote: > > > This is not sufficient since it's still under the > "Ethernet (10 or 100Mbit)" menu. > > What about the patch below? > > config NET_ETHERNET > - bool "Ethernet (10 or 100Mbit)" > + bool "Ethernet (10/100/1000/10000 Mbit)" Ok, this part is obviously sane. However: > +menu "Ethernet (10/100 Mbit)" > + depends on NET_ETHERNET > + > > menu "Gigabit Ethernet (1000/10000 Mbit)" > - depends on NETDEVICES > + depends on NET_ETHERNET is it really sane these days to split out gigabit from the "regular" ethernets? gigabit ethernet is getting quite a bit more common than it used to be, and a lot of the gigabit devices are just "standard ethernet" as far as the user is concerned, and in fact they are often _used_ in just regular 10/100Mbps setups. In other words: it's quite understandable if somebody doesn't even _realize_ that his chip supports gigabit speeds these days. So wouldn't the right fix be to just remove the distinction between "regular" and "gigabit" ethernet, and put them all in the same menu? If the menu then grows really big, maybe we can split it according to some _saner_ split. Not that I can see off-hand what that would be, but.. Linus