From: Linus Torvalds <torvalds@osdl.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] active_load_balance() deadlock
Date: Tue, 1 Jun 2004 13:19:55 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0406011316190.14095@ppc970.osdl.org> (raw)
In-Reply-To: <200406011409.54478.bjorn.helgaas@hp.com>
On Tue, 1 Jun 2004, Bjorn Helgaas wrote:
>
> active_load_balance() looks susceptible to deadlock when busiest==rq.
> Without the following patch, my 128-way box deadlocks consistently
> during boot-time driver init.
Makes sense. The regular "load_balance()" already has that test, although
it also makes it a WARN_ON() for some unexplained reason (I assume
find_busiest_group() isn't supposed to find the local group, although it
doesn't seem to be documented anywhere).
Ingo, Andrew?
Linus
next prev parent reply other threads:[~2004-06-01 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-01 20:09 Bjorn Helgaas
2004-06-01 20:19 ` Linus Torvalds [this message]
2004-06-01 20:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406011316190.14095@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®