From: Linus Torvalds <torvalds@osdl.org>
To: Andy Lutomirski <luto@myrealbox.com>
Cc: Ingo Molnar <mingo@elte.hu>, Andi Kleen <ak@suse.de>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
arjanv@redhat.com, suresh.b.siddha@intel.com,
jun.nakajima@intel.com
Subject: Re: [announce] [patch] NX (No eXecute) support for x86, 2.6.7-rc2-bk2
Date: Fri, 4 Jun 2004 08:36:15 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0406040830200.7010@ppc970.osdl.org> (raw)
In-Reply-To: <200406040826.15427.luto@myrealbox.com>
On Fri, 4 Jun 2004, Andy Lutomirski wrote:
>
> This is wrong on SELinux (and presumably with other LSMs). It also does
> unexpected things if you fail to exec a setuid executable.
Let's not do this at all.
Anything that changes subtle behaviour at suid-execute time is just wrong.
Imagine an app that has been tested in normal use, and then has a subtle
bug when executed set-uid, simply because the address space layout
changes. Or something that mysteriously works when you're root, but not
when you're anything else. Ouch.
I think we should just look at the executable itself, not whether it is
suid. If the executable says it is "NX-approved", then it's NX-approved.
End of story - just try to make sure that as many executables as possible
get compiled with the newer compiler suite that enables it.
Add a tool to let people turn on/off the NX bit on an executable if it
turns out the executable can't work with it (let's say it was compiled and
tested on a CPU without NX support), and everybody should be happy. You
can have a trivial script that turns on the NX bit on all the legacy apps
too, and then if testing shows iot wasn't a good idea, you can turn it off
again on a per-executable basis.
No?
Linus
next prev parent reply other threads:[~2004-06-04 15:37 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 20:50 Ingo Molnar
2004-06-02 21:00 ` Christoph Hellwig
2004-06-02 21:07 ` Ingo Molnar
2004-06-02 21:13 ` Linus Torvalds
2004-06-02 21:17 ` Arjan van de Ven
2004-06-02 21:31 ` Doug McNaught
2004-06-08 8:46 ` Jakub Jelinek
2004-06-03 1:12 ` Joel Becker
2004-06-03 1:27 ` Andi Kleen
2004-06-03 6:24 ` Arjan van de Ven
2004-06-03 20:37 ` jlnance
2004-06-03 7:21 ` Ingo Molnar
2004-06-03 12:44 ` Ingo Molnar
2004-06-03 15:54 ` Andi Kleen
2004-06-03 23:01 ` Andy Lutomirski
2004-06-03 23:08 ` Andi Kleen
2004-06-03 23:54 ` Andy Lutomirski
2004-06-04 0:05 ` Andy Lutomirski
2004-06-04 9:25 ` Ingo Molnar
2004-06-04 15:26 ` Andy Lutomirski
2004-06-04 15:36 ` Linus Torvalds [this message]
2004-06-04 15:41 ` Arjan van de Ven
2004-06-04 15:47 ` Linus Torvalds
2004-06-04 15:51 ` Arjan van de Ven
2004-06-04 16:02 ` Linus Torvalds
2004-06-04 16:13 ` Andi Kleen
2004-06-04 16:37 ` Arjan van de Ven
2004-06-04 16:40 ` Christoph Hellwig
2004-06-04 17:27 ` David Mosberger
2004-06-04 17:30 ` Andi Kleen
2004-06-08 9:07 ` Jakub Jelinek
2004-06-08 9:14 ` Andi Kleen
2004-06-08 9:19 ` Arjan van de Ven
2004-06-04 16:51 ` Ulrich Drepper
2004-06-08 17:15 ` Bill Davidsen
2004-06-04 18:11 ` Gerhard Mack
2004-06-04 18:12 ` Arjan van de Ven
2004-06-04 16:06 ` Ingo Molnar
2004-06-04 17:20 ` Ingo Molnar
2004-06-04 17:22 ` Ingo Molnar
2004-06-04 17:32 ` Ingo Molnar
2004-06-03 19:24 ` Suresh Siddha
2004-06-03 20:37 ` Andi Kleen
2004-06-03 22:58 ` Suresh Siddha
2004-06-03 23:06 ` Andi Kleen
2004-06-04 9:30 ` Ingo Molnar
2004-06-03 12:57 ` Brian Gerst
2004-06-04 9:39 ` Ingo Molnar
2004-06-04 10:41 ` Christoph Hellwig
2004-06-04 10:48 ` William Lee Irwin III
2004-06-03 16:21 ` Ulrich Drepper
2004-06-03 19:30 ` Kurt Garloff
2004-06-02 21:43 ` Andi Kleen
2004-06-03 0:11 ` Rusty Russell
2004-06-03 0:17 ` Jeff Garzik
2004-06-03 7:24 ` Ingo Molnar
2004-06-03 8:47 ` Ingo Molnar
2004-06-03 8:53 ` Ingo Molnar
2004-06-04 0:04 ` Rusty Russell
2004-06-03 9:07 ` Ingo Molnar
2004-06-03 14:36 ` Gerhard Mack
2004-06-03 16:22 ` Arjan van de Ven
2004-06-04 9:36 ` Ingo Molnar
2004-06-04 11:59 ` Stephen Wille Padnos
[not found] <22L0f-5Ci-11@gated-at.bofh.it>
[not found] ` <22O7J-8dw-11@gated-at.bofh.it>
[not found] ` <22Wf4-5Xv-23@gated-at.bofh.it>
2004-06-03 9:43 ` Andi Kleen
2004-06-04 18:01 Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406040830200.7010@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjanv@redhat.com \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@myrealbox.com \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®