From: Linus Torvalds <torvalds@osdl.org>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: linux-kernel@vger.kernel.org, perex@suse.cz
Subject: Re: [RFC] ASLA design, depth of code review and lack thereof
Date: Fri, 4 Jun 2004 16:29:20 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0406041622480.7010@ppc970.osdl.org> (raw)
In-Reply-To: <20040604230819.GR12308@parcelfarce.linux.theplanet.co.uk>
On Sat, 5 Jun 2004 viro@parcelfarce.linux.theplanet.co.uk wrote:
>
>
> case SNDRV_PCM_FORMAT_FLOAT_BE:
> {
> union {
> float f;
> u_int32_t i;
> } u;
> u.f = 0.0;
> #ifdef SNDRV_LITTLE_ENDIAN
> return bswap_32(u.i);
> #else
> return u.i;
> #endif
So what I wonder about is why anybody does something like this in the
first place?
Any IEEE format architecture will make 0.0 be all-zeroes, last I saw. In
fact, any architecture (IEEE or not) where that isn't true will have
serious problems with floating point values in bss (hint: the bss isn't
initialzed to 0.0, it's initialized to the bit pattern 0).
So what the above boils dow to is a very very strange way of writing
return 0;
and it has absolutely _zero_ to do with "little-endian" or anything else
for that matter.
Linus
next prev parent reply other threads:[~2004-06-04 23:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-04 23:08 viro
2004-06-04 23:14 ` viro
2004-06-04 23:29 ` Linus Torvalds [this message]
2004-06-05 0:04 ` viro
2004-06-07 13:14 ` Takashi Iwai
2004-06-07 22:40 ` viro
2004-06-08 12:49 ` Takashi Iwai
2004-06-07 13:10 ` Takashi Iwai
2004-06-04 23:37 ` Jeff Garzik
2004-06-07 13:24 ` Takashi Iwai
2004-06-07 13:47 ` Jeff Garzik
2004-06-07 13:57 ` Takashi Iwai
2004-06-07 14:05 ` Jeff Garzik
2004-06-07 14:12 ` Takashi Iwai
2004-06-07 14:18 ` Russell King
2004-06-08 13:27 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406041622480.7010@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®