From: Linus Torvalds <torvalds@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: ktech@wanadoo.es,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Manfred Spraul <manfred@colorfullife.com>
Subject: Re: 2.6.7-rc1 breaks forcedeth
Date: Sun, 6 Jun 2004 11:32:32 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0406061127200.7010@ppc970.osdl.org> (raw)
In-Reply-To: <40C360C4.7010703@pobox.com>
On Sun, 6 Jun 2004, Jeff Garzik wrote:
>
> So by definition it is a driver bug if the hardware is sending irqs
> outside of when the driver indicates interest in the irq via
> request_irq...free_irq.
Fair enough. It's sometimes easier to just register the driver irq early,
though, to take care of all the cases that can happen. In particular, if
you know you may have pending interrupts, and your irq handler is good at
clearing them (it had better be), the easiest solution may well be to just
register early.
> Also, PCI 2.3 devices have an "interrupt disable" bit in PCI_COMMAND
> they can use, iff (a) it's implemented and (b) the driver isn't using MSI.
Now _this_ will help. However, I suspect it will help three years down the
line, not now. It should have been there originally, it would have solved
a lot of problems.
Linus
next prev parent reply other threads:[~2004-06-06 18:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-06 1:59 ktech
2004-06-06 3:14 ` Linus Torvalds
2004-06-06 8:36 ` Manfred Spraul
2004-06-06 17:04 ` Linus Torvalds
2004-06-06 18:13 ` Jeff Garzik
2004-06-06 18:21 ` Jeff Garzik
2004-06-06 18:32 ` Linus Torvalds [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-16 18:40 David Mansfield
2004-06-06 13:49 jjluza
[not found] <E1BWxTh-0002dx-KR@mb06.in.mad.eresmas.com>
2004-06-06 13:31 ` Daniel Schmitt
2004-06-06 12:10 ktech
2004-06-06 12:53 ` Vincent van de Camp
2004-06-06 13:40 ` Manfred Spraul
2004-06-06 14:17 ` Manfred Spraul
2004-06-05 23:41 Luis Miguel García Mancebo
2004-06-05 23:50 ` Linus Torvalds
2004-05-31 0:29 jjluza
2004-05-30 17:54 Luis Miguel García Mancebo
2004-05-30 20:47 ` Jeff Garzik
2004-05-30 15:57 Lee Howard
2004-05-30 17:20 ` Jeff Garzik
2004-05-30 22:59 ` Lee Howard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406061127200.7010@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=jgarzik@pobox.com \
--cc=ktech@wanadoo.es \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®