From: Linus Torvalds <torvalds@osdl.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Greg Weeks <greg.weeks@timesys.com>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.4] jffs2 aligment problems
Date: Mon, 7 Jun 2004 09:03:07 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0406070900010.6162@ppc970.osdl.org> (raw)
In-Reply-To: <200406071736.53101.tglx@linutronix.de>
On Mon, 7 Jun 2004, Thomas Gleixner wrote:
>
> On Monday 07 June 2004 17:08, Greg Weeks wrote:
> > This fixed some jffs2 alignment problems we saw on an IXP425 based
> > XScale board. I just got pinged that I was supposed to post this patch
> > in case anyone else finds it usefull. This was against a modified 2.4.19
> > kernel.
>
> Enable CONFIG_ALIGNMENT_TRAP instead of tweaking the code.
> JFFS2 / MTD must be allowed to do unaligned access
Wrong.
Pleas fix jffs2 to use the proper "get_unaligned()"/"put_unaligned()"
instead.
Emulating unaligned accesses with traps (even even the architecture
supports it, which isn't universally true) is _stupid_ when we have
perfectly well-defined macros for them that do it faster and are
_designed_ for this.
On architectures where it doesn't matter, the macros just do the access,
so it's not like you're slowing anything down.
Linus
next prev parent reply other threads:[~2004-06-07 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-07 15:08 Greg Weeks
2004-06-07 15:36 ` Thomas Gleixner
2004-06-07 16:03 ` Linus Torvalds [this message]
2004-06-07 16:41 ` Russell King
2004-06-07 19:14 ` David Woodhouse
2004-06-07 19:22 ` Linus Torvalds
2004-06-07 20:39 ` David Woodhouse
2004-06-07 20:54 ` Linus Torvalds
2004-06-07 20:56 ` Thomas Gleixner
2004-06-07 21:29 ` David Woodhouse
2004-06-07 21:40 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406070900010.6162@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=greg.weeks@timesys.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®