From: Linus Torvalds <torvalds@osdl.org>
To: BlaisorBlade <blaisorblade_spam@yahoo.it>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Subject: Re: [PATCH] Missing BKL in sys_chroot() for 2.6
Date: Mon, 7 Jun 2004 11:56:37 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0406071150560.1637@ppc970.osdl.org> (raw)
In-Reply-To: <200406061958.48262.blaisorblade_spam@yahoo.it>
On Sun, 6 Jun 2004, BlaisorBlade wrote:
>
> (PLEASE cc me on replies as I'm not subscribed).
>
> Set_fs_root *claims* it wants the BKL held:
I think the set_fs_root() comment is just wrong.
We properly lock the accesses to root/rootmnt with "fs->lock", and in fact
no other users will have the BKL when accessing them anyway, so I don't
see what the BKL would help in this case.
However, from a quick grep of users, it does look like some other users
aren't real careful with "fs->lock" (ie chroot_fs_refs() looks like it
could have problems - probably purely theoretical).
Al, do your eagle-eyes see something I missed?
Linus
next prev parent reply other threads:[~2004-06-07 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-06 17:58 BlaisorBlade
2004-06-07 18:56 ` Linus Torvalds [this message]
2004-06-07 19:13 ` Phy Prabab
2004-06-07 19:18 ` Linus Torvalds
2004-06-07 19:33 ` Phy Prabab
2004-06-07 22:53 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406071150560.1637@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=blaisorblade_spam@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®