From: Dave Airlie <airlied@linux.ie>
To: "Robert T. Johnson" <rtjohnso@eecs.berkeley.edu>
Cc: dri-devel@lists.sourceforge.net,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: 2.6.7-rc3 drivers/char/drm/gamma_dma.c: several user/kernel pointer bugs
Date: Thu, 10 Jun 2004 10:46:12 +0100 (IST) [thread overview]
Message-ID: <Pine.LNX.4.58.0406101044130.12229@skynet> (raw)
In-Reply-To: <1086821620.32053.120.camel@dooby.cs.berkeley.edu>
> gamma_dma_priority and gamma_dma_send_buffers both deref d->send_indices
> and/or d->send_sizes. When these functions are called from gamma_dma,
> these pointers are user pointers and are thus not safe to deref. This patch
> copies over the pointers inside gamma_dma_priority and
> gamma_dma_send_buffers. Let me know if you have any questions or if I've
> made a mistake.
okay I've checked this into the drm bk tree and DRM CVS, I've no way to
test it apart from visual inspection and it compiles, I've asked Linus to
sync the drm tree again, I probably need to add some __user annotations in
a few places..
Dave.
--
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person
next prev parent reply other threads:[~2004-06-10 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 22:53 Robert T. Johnson
2004-06-10 2:03 ` viro
2004-06-10 8:35 ` Dave Airlie
2004-06-10 9:46 ` Dave Airlie [this message]
2004-06-10 20:37 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406101044130.12229@skynet \
--to=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rtjohnso@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®