From: Linus Torvalds <torvalds@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: chrisw@osdl.org, linux-kernel@vger.kernel.org, mika@osdl.org
Subject: Re: [PATCH] security_sk_free void return fixup
Date: Tue, 15 Jun 2004 20:04:35 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0406152002500.4142@ppc970.osdl.org> (raw)
In-Reply-To: <20040615200003.0100392a.akpm@osdl.org>
On Tue, 15 Jun 2004, Andrew Morton wrote:
> >
> > I'm going to remove this warning from sparse. Apparently it is valid C99,
>
> yes, but in every(?) case where it triggered, the kernel code was wrong.
Is that true? Hmm. That would indeed be a strong argument. However, I was
also a bit alarmed by how one of the fixes for this warning was itself
actually buggy by dropping the "return" statement altogether and falling
through.
> So I'd suggest the warning be retained, perhaps with an option to enable
> it.
Hmm. Sparse already has a "verbose" level, although right now it's not
actually used by anything (it used to enable some warnings that were due
to sparse deficiencies, but I fixed that particular problem).
Linus
next prev parent reply other threads:[~2004-06-16 3:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-15 23:16 Chris Wright
2004-06-16 2:53 ` Linus Torvalds
2004-06-16 3:00 ` Andrew Morton
2004-06-16 3:04 ` Linus Torvalds [this message]
2004-06-16 12:11 ` Dick Streefland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406152002500.4142@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®