From: Linus Torvalds <torvalds@osdl.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: 2.6.7-bk: asm/setup.h and linux/init.h
Date: Sat, 26 Jun 2004 09:05:57 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0406260903190.14449@ppc970.osdl.org> (raw)
In-Reply-To: <20040626153511.A30532@flint.arm.linux.org.uk>
On Sat, 26 Jun 2004, Russell King wrote:
>
> Is there a reason why we can't delete asm/setup.h from linux/init.h
> and change that declaration to:
>
> +extern char saved_command_line[];
Yes. A number of achitectures use something like
strlcpy(saved_command_line, cmd_line, sizeof(saved_command_line));
and that "sizeof()" would require the full declaration.
However, I don't see any reason why we couldn't make that sizeof be
COMMAND_LINE_SIZE instead, if somebody is willing to grep and do the
conversion and make sure everybody who now uses it has <asm/setup.h>
included.
Hmm?
Linus
next prev parent reply other threads:[~2004-06-26 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-26 14:35 Russell King
2004-06-26 16:05 ` Linus Torvalds [this message]
2004-06-26 16:49 ` Russell King
2004-06-26 23:24 ` Paul Jackson
2004-06-26 23:34 ` Rusty Russell
2004-06-26 23:56 ` Paul Jackson
2004-06-26 23:30 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0406260903190.14449@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®