From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266622AbUGKQOO (ORCPT ); Sun, 11 Jul 2004 12:14:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266623AbUGKQOO (ORCPT ); Sun, 11 Jul 2004 12:14:14 -0400 Received: from fw.osdl.org ([65.172.181.6]:55948 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266622AbUGKQON (ORCPT ); Sun, 11 Jul 2004 12:14:13 -0400 Date: Sun, 11 Jul 2004 09:14:01 -0700 (PDT) From: Linus Torvalds To: Geert Uytterhoeven cc: Roman Zippel , Linux Kernel Development Subject: Re: [PATCH] Use NULL instead of integer 0 in security/selinux/ In-Reply-To: Message-ID: References: <20040707122525.X1924@build.pdx.osdl.net> <20040707202746.1da0568b.davem@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Jul 2004, Geert Uytterhoeven wrote: > > But why does sparse complain about > > p->thread.fs = get_fs().seg; Sparse bug. Hey, it's not perfect, and this case is actually very easy to just parse, but harder to build a nice internal representation of it. In particular, sparse internally really _should_ re-write the above as fnret = get_fs(); p->thread.fs = fnret.seg; since that is what would happen in real life, but since it never came up in early testing, I didn't ever really get around to doing it that way. Oh, well. So please don't take _all_ sparse warnings too seriously. Some of them literally are still due to sparse limitations. I'm happy to say that they are fairly few these days. Linus