From: Ingo Molnar <mingo@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Zwane Mwaikambo <zwane@linuxpower.ca>,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: 2.6.8-rc2-mm1
Date: Sun, 1 Aug 2004 07:16:24 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0408010715480.23711@devserv.devel.redhat.com> (raw)
In-Reply-To: <20040731132153.0763ce8f.akpm@osdl.org>
On Sat, 31 Jul 2004, Andrew Morton wrote:
> Sorry. Try this one instead.
>
> --- 25/fs/jbd/checkpoint.c~journal_clean_checkpoint_list-latency-fix-fix 2004-07-31 11:43:39.320530424 -0700
> +++ 25-akpm/fs/jbd/checkpoint.c 2004-07-31 13:20:22.562303576 -0700
> @@ -497,8 +497,8 @@ int __journal_clean_checkpoint_list(jour
> * We don't test cond_resched() here because another CPU could
> * be waiting on j_list_lock() while holding a different lock.
> */
> - if ((ret & 127) == 127) {
> - spin_unlock(&journal->j_list_lock);
> + transaction = journal->j_checkpoint_transactions
> + if (transaction && (ret & 127) == 127) {
this should cause a crash later on - 'transaction' is also the loop
variable here.
Ingo
next prev parent reply other threads:[~2004-08-01 11:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 9:04 2.6.8-rc2-mm1 Andrew Morton
2004-07-28 16:36 ` 2.6.8-rc2-mm1 Jesse Barnes
2004-07-28 17:08 ` 2.6.8-rc2-mm1 (compile stats) John Cherry
2004-07-28 19:37 ` 2.6.8-rc2-mm1 Peter Osterlund
2004-07-28 22:24 ` 2.6.8-rc2-mm1 Johannes Stezenbach
2004-07-28 22:44 ` 2.6.8-rc2-mm1 viro
2004-07-28 23:24 ` 2.6.8-rc2-mm1 Johannes Stezenbach
2004-07-28 23:34 ` 2.6.8-rc2-mm1 Andrew Morton
2004-07-29 0:08 ` 2.6.8-rc2-mm1 Johannes Stezenbach
2004-07-29 6:42 ` 2.6.8-rc2-mm1 Andrew Morton
2004-07-29 19:35 ` 2.6.8-rc2-mm1 Michael Hunold
2004-07-29 21:02 ` 2.6.8-rc2-mm1 Andrew Morton
2004-07-28 22:49 ` 2.6.8-rc2-mm1 Adam Kropelin
2004-07-28 23:20 ` 2.6.8-rc2-mm1 Andrew Morton
2004-07-28 23:13 ` 2.6.8-rc2-mm1 Paul Jackson
2004-07-29 14:36 ` 2.6.8-rc2-mm1 Adrian Bunk
2004-07-29 19:36 ` 2.6.8-rc2-mm1 David Woodhouse
2004-07-29 14:41 ` 2.6.8-rc2-mm1: NTFS compile error with gcc 2.95 Adrian Bunk
2004-07-29 15:54 ` Jan-Benedict Glaw
2004-07-29 20:42 ` [patch] " Adrian Bunk
[not found] ` <Pine.LNX.4.60.0407292249120.25661@hermes-1.csi.cam.ac.uk>
2004-07-29 23:18 ` Adrian Bunk
2004-07-29 21:27 ` 2.6.8-rc2-mm1: DVB: "errno" undefined Adrian Bunk
2004-07-29 22:44 ` Kenneth Aafløy
2004-07-29 23:24 ` Adrian Bunk
2004-07-30 14:30 ` Arnd Bergmann
2004-07-31 10:09 ` 2.6.8-rc2-mm1 breaks PPPoE for me (was: 2.6.8-rc2-mm1) Matthias Andree
2004-07-31 16:39 ` 2.6.8-rc2-mm1 Zwane Mwaikambo
2004-07-31 18:47 ` 2.6.8-rc2-mm1 Andrew Morton
2004-07-31 19:54 ` 2.6.8-rc2-mm1 Zwane Mwaikambo
2004-07-31 20:09 ` 2.6.8-rc2-mm1 Zwane Mwaikambo
2004-07-31 20:21 ` 2.6.8-rc2-mm1 Andrew Morton
2004-08-01 4:21 ` 2.6.8-rc2-mm1 Zwane Mwaikambo
2004-08-01 11:16 ` Ingo Molnar [this message]
2004-08-01 11:05 ` 2.6.8-rc2-mm1 Ingo Molnar
2004-08-01 2:36 ` 2.6.8-rc2-mm1 William Lee Irwin III
2004-08-01 8:05 ` 2.6.8-rc2-mm1 Andrew Morton
2004-08-01 12:33 ` 2.6.8-rc2-mm1 William Lee Irwin III
2004-08-01 21:11 ` 2.6.8-rc2-mm1 Sam Ravnborg
2004-08-01 23:57 ` 2.6.8-rc2-mm1 William Lee Irwin III
2004-08-03 20:46 ` 2.6.8-rc2-mm1 Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0408010715480.23711@devserv.devel.redhat.com \
--to=mingo@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome