From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266787AbUHDFTl (ORCPT ); Wed, 4 Aug 2004 01:19:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267253AbUHDFTl (ORCPT ); Wed, 4 Aug 2004 01:19:41 -0400 Received: from dragnfire.mtl.istop.com ([66.11.160.179]:16096 "EHLO dsl.commfireservices.com") by vger.kernel.org with ESMTP id S266787AbUHDFTj (ORCPT ); Wed, 4 Aug 2004 01:19:39 -0400 Date: Wed, 4 Aug 2004 01:23:25 -0400 (EDT) From: Zwane Mwaikambo To: Nigel Cunningham Cc: Linux Kernel Mailing List Subject: Re: MTRR driver model support broken on SMP. In-Reply-To: <1091585241.3303.6.camel@laptop.cunninghams> Message-ID: References: <1091585241.3303.6.camel@laptop.cunninghams> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Aug 2004, Nigel Cunningham wrote: > MTRR driver support is broken on SMP because it calls smp functions with > interrupts disabled, but interrupts should be disabled because it is > called via device_power_up. > > Badness in smp_call_function at arch/i386/kernel/smp.c:565 > [] dump_stack+0x1e/0x20 > [] smp_call_function+0x12b/0x137 > [] set_mtrr+0x67/0x121 > [] mtrr_restore+0x4f/0x73 > [] sysdev_resume+0x6f/0xf0 > [] device_power_up+0x8/0xf Looking at this i'm really curious as to whether we need to bother at all, can you remove the mtrr restore code and then compare /proc/mtrr before and after suspending.